Bug 19646 - value_builder marc21_linking_section template is broken
Summary: value_builder marc21_linking_section template is broken
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Fridolin SOMERS
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on: 14828
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-17 12:54 UTC by Fridolin SOMERS
Modified: 2017-12-07 12:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19646: fix value_builder marc21_linking_section template (4.12 KB, patch)
2017-11-17 13:07 UTC, Fridolin SOMERS
Details | Diff | Splinter Review
Bug 19646: fix value_builder marc21_linking_section template (4.18 KB, patch)
2017-11-17 13:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19646: fix value_builder marc21_linking_section template (4.27 KB, patch)
2017-11-24 08:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19646: (QA follow-up) Fix tab character (2.25 KB, patch)
2017-11-24 08:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin SOMERS 2017-11-17 12:54:32 UTC
When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not covered by tests! at /home/koha/src/C4/Templates.pm line 122.
Comment 1 Fridolin SOMERS 2017-11-17 13:07:49 UTC
Created attachment 69193 [details] [review]
Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not covered by tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined in itypeloo.

This patch removes this condition because all item types are fetched from database, there is not one selected.
It sets "All item types" as selected.
Also correctes two errors in HTML : ending form and div, "<a_class=" instead of "<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on 773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine
Comment 2 Owen Leonard 2017-11-17 13:22:13 UTC
Created attachment 69194 [details] [review]
Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.

This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
   773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2017-11-24 08:32:51 UTC
Created attachment 69330 [details] [review]
Bug 19646: fix value_builder marc21_linking_section template

When using marc21_linking_section cataloging plugin, you get the error :
Template process failed: undef error - The method selected is not
covered by tests! at /home/koha/src/C4/Templates.pm line 122.

It commes from [% IF ( itypeloo.selected ) %], selected is not defined
in itypeloo.

This patch removes this condition because all item types are fetched
from database, there is not one selected. It sets "All item types" as
selected. Also correctes two errors in HTML : ending form and div,
"<a_class=" instead of "<a class="

Test plan :
1) Use a MARC21 database
2) Define marc21_linking_section cataloging plugin in framework, on
   773$t for example
3) Create a new biblio record
4) Click on icon in 773$t
5) Check plugin works fine

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2017-11-24 08:32:56 UTC
Created attachment 69331 [details] [review]
Bug 19646: (QA follow-up) Fix tab character

Resolve qa tools warning:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 172)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2017-11-24 08:33:29 UTC
Changes do not seem to affect translation.
Comment 6 Jonathan Druart 2017-11-28 20:10:36 UTC
Erk, I missed this one!
Comment 7 Marcel de Rooy 2017-11-29 12:13:13 UTC
(In reply to Jonathan Druart from comment #6)
> Erk, I missed this one!

You missed much more. Too bad.
Comment 8 Jonathan Druart 2017-11-29 17:10:09 UTC
Caused by commit aafe73eefb5151454fa8957bf188768324d23955
Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used
Comment 9 Jonathan Druart 2017-12-07 12:40:20 UTC
Pushed to master for 18.05, thanks to everybody involved!