In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the batch MARC tools templates.
Created attachment 69236 [details] [review] Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc.
When testing the Batch item modification, after entering barcodes and continuing I get: ReferenceError: $ is not defined. Batchmod.pl:861:1
Created attachment 69740 [details] [review] Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. Revised: My original patch included changes to batchMod-edit.tt but didn't take into account the MARC plugins which are loaded in the item edit form. I have discarded those changes for now. Tools -> Batch record modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit records for deletion - Page highlighting in the sidebar - Checkbox selection links - Warning when no records selected - Patron autocomplete in the "Check out" tab Tools -> Batch item modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab Tools -> Batch item deletion - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit items for deletion - Patron autocomplete in the "Check out" tab - Checkbox selection links - Column-hiding checkboxes - Datatables Tools -> Batch record modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit records for modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Checkbox selection links - Datatables - MARC preview - Warning when no records selected - Progress bar after submitting items for modification
Created attachment 69770 [details] [review] Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. Revised: My original patch included changes to batchMod-edit.tt but didn't take into account the MARC plugins which are loaded in the item edit form. I have discarded those changes for now. Tools -> Batch record modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit records for deletion - Page highlighting in the sidebar - Checkbox selection links - Warning when no records selected - Patron autocomplete in the "Check out" tab Tools -> Batch item modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab Tools -> Batch item deletion - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit items for deletion - Patron autocomplete in the "Check out" tab - Checkbox selection links - Column-hiding checkboxes - Datatables Tools -> Batch record modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit records for modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Checkbox selection links - Datatables - MARC preview - Warning when no records selected - Progress bar after submitting items for modification Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 69774 [details] [review] Bug 19654: Move tools templates JavaScript to the footer: Batch MARC tools This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. Revised: My original patch included changes to batchMod-edit.tt but didn't take into account the MARC plugins which are loaded in the item edit form. I have discarded those changes for now. Tools -> Batch record modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit records for deletion - Page highlighting in the sidebar - Checkbox selection links - Warning when no records selected - Patron autocomplete in the "Check out" tab Tools -> Batch item modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab Tools -> Batch item deletion - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit items for deletion - Patron autocomplete in the "Check out" tab - Checkbox selection links - Column-hiding checkboxes - Datatables Tools -> Batch record modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Submit records for modification - Page highlighting in the sidebar - Patron autocomplete in the "Check out" tab - Checkbox selection links - Datatables - MARC preview - Warning when no records selected - Progress bar after submitting items for modification Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Enhancement, not backporting for 17.11