Bug 19661 - Add routes for funds
Summary: Add routes for funds
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: REST api (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Matthias Meusburger
QA Contact:
URL: https://wiki.koha-community.org/wiki/...
Whiteboard:
Keywords: needs_rfc
Depends on: 19826
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-21 07:52 UTC by Matthias Meusburger
Modified: 2018-02-27 13:56 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
REST API: Funds Endpoint (12.87 KB, patch)
2017-11-21 07:53 UTC, Matthias Meusburger
Details | Diff | Splinter Review
Bug 19661 - REST API: Funds Endpoint (12.96 KB, patch)
2017-12-15 20:59 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 19661 - Use Koha::Acquisition::Funds instead of C4::Budgets (1.21 KB, patch)
2018-01-17 10:51 UTC, Matthias Meusburger
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Meusburger 2017-11-21 07:52:11 UTC
This patch adds a new route to the REST api:

api/v1/acquisitions/funds/

It allows to retrieve funds informations, possibly using filters.
Comment 1 Matthias Meusburger 2017-11-21 07:53:08 UTC
Created attachment 69243 [details] [review]
REST API: Funds Endpoint

This patch adds a new route to the REST api:

api/v1/acquisitions/funds/
Comment 2 David Bourgault 2017-12-15 20:59:23 UTC
Created attachment 69833 [details] [review]
Bug 19661 - REST API: Funds Endpoint

This patch adds a new route to the REST api:

api/v1/acquisitions/funds/

https://bugs.koha-community.org/show_bug.cgi?id=19661

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 3 Tomás Cohen Arazi 2017-12-15 21:31:09 UTC
Matthias, everything looks ok. Could you please describe the enpdoint here:

https://wiki.koha-community.org/wiki/REST_api_RFCs

(You can copy and paste from https://wiki.koha-community.org/wiki/Patrons_endpoint_RFC and adapt it).

Also, would you consider implementing it using the objects.search implementation from Julian?
Comment 4 Katrin Fischer 2017-12-26 16:03:22 UTC
Should we move this out of the queue until 19826 is ready and this can be redone on top?
Comment 5 Matthias Meusburger 2018-01-17 10:51:06 UTC
Created attachment 70603 [details] [review]
Bug 19661 - Use Koha::Acquisition::Funds instead of C4::Budgets
Comment 6 Matthias Meusburger 2018-01-17 11:16:36 UTC
Documentation updated here: https://wiki.koha-community.org/wiki/Acquisitions_funds_endpoint_RFC
Comment 7 Tomás Cohen Arazi 2018-01-18 13:07:06 UTC
I think this work needs a review, as some (relevant) attributes are missing on the fund definition:

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Schema/Result/Aqbudget.pm;h=12a8c8d730afe8a1557e836742a7cafd33255388;hb=HEAD
Comment 8 Tomás Cohen Arazi 2018-02-27 13:56:49 UTC
I've added the ''needs_rfc'' keyword to this bug. The community process requires a vote on the RFC, so the dev and interested parties should take care of adding the RFC to the agenda on a dev meeting, and gather support for it.