Bug 19695 - Uncertain prices should not use find in list context
Summary: Uncertain prices should not use find in list context
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Stefan Berndtsson
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 15685 18539
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-27 11:41 UTC by Stefan Berndtsson
Modified: 2017-12-11 08:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Fix another instance of ->find in list context. (1006 bytes, patch)
2017-11-27 11:41 UTC, Stefan Berndtsson
Details | Diff | Splinter Review
Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl) (1.04 KB, patch)
2017-11-27 17:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Berndtsson 2017-11-27 11:41:12 UTC
When clicking on Uncertain prices button from a basket, the log fails with the following message:
Cannot use "->find" in list context at <path>/acqui/uncertainprice.pl line 76.

Similar to Bug 18179.
Comment 1 Stefan Berndtsson 2017-11-27 11:41:44 UTC
Created attachment 69369 [details] [review]
Fix another instance of ->find in list context.
Comment 2 Jonathan Druart 2017-11-27 17:23:42 UTC
Created attachment 69396 [details] [review]
Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2017-11-27 17:24:36 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2017-11-27 17:26:25 UTC
Patch pushed to master for 17.11, thanks Stefan!
Comment 5 Fridolin SOMERS 2017-12-11 08:11:27 UTC
Depends on Bug 15685 which adds this line.
Comment 6 Fridolin SOMERS 2017-12-11 08:12:02 UTC
Bug 15685 not in 17.05.x