In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for some of the serials templates.
Created attachment 69570 [details] [review] Bug 19758: Move template JavaScript to the footer: Serials, part 1 This patch modifies some staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Search for a vendor - "Choose" link and "Cancel" button should work correctly - Search for record - "Choose" link and "Cancel" button should word correctly - Serials -> Add subscription fields - Datatable, delete confirmation - Edit - Form validation (submit both authorised value and MARC field) - Serials -> Check expiration - Date picker in search form - Search - Renew button triggers popup - Serials -> Claims -> Search results - Date picker, datatable, form validation - Select all/none; Download claims
Created attachment 69604 [details] [review] Bug 19758: Move template JavaScript to the footer: Serials, part 1 This patch modifies some staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Search for a vendor - "Choose" link and "Cancel" button should work correctly - Search for record - "Choose" link and "Cancel" button should word correctly - Serials -> Add subscription fields - Datatable, delete confirmation - Edit - Form validation (submit both authorised value and MARC field) - Serials -> Check expiration - Date picker in search form - Search - Renew button triggers popup - Serials -> Claims -> Search results - Date picker, datatable, form validation - Select all/none; Download claims Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 69788 [details] [review] Bug 19758: Move template JavaScript to the footer: Serials, part 1 This patch modifies some staff client serials templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Serials -> New subscription - Search for a vendor - "Choose" link and "Cancel" button should work correctly - Search for record - "Choose" link and "Cancel" button should word correctly - Serials -> Add subscription fields - Datatable, delete confirmation - Edit - Form validation (submit both authorised value and MARC field) - Serials -> Check expiration - Date picker in search form - Search - Renew button triggers popup - Serials -> Claims -> Search results - Date picker, datatable, form validation - Select all/none; Download claims Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Enhancement, not backporting for 17.11