Bug 19941 - 'alt' and 'title' attributes of the item type image are not set when a hold is placed
Summary: 'alt' and 'title' attributes of the item type image are not set when a hold i...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 19940
Blocks:
  Show dependency treegraph
 
Reported: 2018-01-09 17:04 UTC by Jonathan Druart
Modified: 2018-03-23 18:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19940: Koha::Biblio - Remove GetBiblioItemInfosOf (2.56 KB, patch)
2018-01-09 17:08 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-01-09 17:04:16 UTC
From reserve/request.tt:

-              <img src="[% biblioloo.imageurl %]" alt="[% biblioloo.itypename %]" title="[% biblioloo.itypename %]" />

But this itypename is never set.

From the controller:
$biblioloopiter{description} = $biblioitem->{description};
$biblioloopiter{itypename}   = $biblioitem->{description};

$biblioitem comes from GetBiblioItemInfosOf which does not retrieve "description"
Comment 1 Jonathan Druart 2018-01-09 17:08:23 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2018-03-05 15:05:10 UTC
Jonathan, it seems to me that you submitted the patch for bug 19440 here, and forgot about this specific bug you were trying to fix.
Comment 3 Jonathan Druart 2018-03-23 18:37:38 UTC
(In reply to Tomás Cohen Arazi from comment #2)
> Jonathan, it seems to me that you submitted the patch for bug 19440 here,
> and forgot about this specific bug you were trying to fix.

Sounds like I lost that patch, or never wrote it!