There are several single-column Circulation templates which can be updated to use the Bootstrap grid. - serials\acqui-search-result.tt - serials\acqui-search.tt - serials\result.tt - serials\subscription-bib-search.tt
Created attachment 70707 [details] [review] Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct.
hiya, acqui-search.tt is mising the bootstrap grid.
(In reply to Claire Gravely from comment #2) > hiya, > acqui-search.tt is mising the bootstrap grid. Ignore that. Everything is lovely!
(In reply to Claire Gravely from comment #3) > (In reply to Claire Gravely from comment #2) > > hiya, > > acqui-search.tt is mising the bootstrap grid. > > Ignore that. Everything is lovely! Sorry, double checked the wrong bit :| It does seem to be missing.
Created attachment 71269 [details] [review] Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct.
I submitted a follow-up to make this patch more consistent, but: It's not that acqui-search.tt was missing the Bootstrap grid, it's that it has minimal Bootstrap markup because it's a very simple template. It's not really necessary to define columns and rows when there aren't multiples of either.
Created attachment 71350 [details] [review] Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Created attachment 71908 [details] [review] Bug 20037: Switch single-column templates to Bootstrap grid: Serials This patch updates several single-column Serials module templates to use the Bootstrap grid. In addition to grid changes, some templates have been modified to include the footer with the correct popup parameter. - serials\acqui-search.tt - Go to Serials -> New subscription. Click "Search for a vendor." - serials\acqui-search-result.tt - Vendor search results - serials\result.tt - Click "Search for record." - serials\subscription-bib-search.tt - Catalog search results. Each of these pages should look correct. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, not backported for 17.11