Bug 20055 - New suggestion from OPAC records borrowernumber instead of branchcode
Summary: New suggestion from OPAC records borrowernumber instead of branchcode
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 17.05
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-22 08:05 UTC by Bob Birchall
Modified: 2018-12-03 20:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Birchall 2018-01-22 08:05:37 UTC
A new suggestion, from a user logged into the OPAC, causes the borrowernumber to be written to both the 'suggestedby' and 'branchcode' fields of the suggestions table. 

Version 17.05.06 on Debian 8, from packages. Until we upgraded from 16.11.11, both fields were written correctly. Sys pref settings:
- suggestion : Allow
- AnonSuggestions: Don't allow
- AllowPurchaseSuggestionBranchChoice : Don't allow

To check the error:
- log in to the OPAC;
- enter a new purchase suggestion;
- log into the staff client: attempting to display the new suggestion fails due to the invalid branchcode;
- locate the new suggestion in the database: observe that branchcode field contains the borrowernumber.
Comment 1 Jonathan Druart 2018-01-22 20:34:35 UTC
Works for me on master and 17.05.06

Nothing in the logs?
Comment 2 Bob Birchall 2018-01-31 06:00:29 UTC
(In reply to Jonathan Druart from comment #1)
> Works for me on master and 17.05.06
> 
> Nothing in the logs?

Well, apparently we were running a patch which was needed for mellon/SSO to work.

17.05.x broke the patch, due to an API change to GetMember().

A one line update fixed the error.

My understanding is there are no implications for Koha. So I guess we can close this.

Thanks Jonathan.