See bug 18811 and 20074. We should not expect 0, 1 and 8. But only 0 and -5. (Note that it is just used as a boolean, so not a big deal.)
This needs to be pushed along with bug 20074 otherwise the new installs will contain wrong values.
(In reply to Jonathan Druart from comment #1) > This needs to be pushed along with bug 20074 otherwise the new installs will > contain wrong values. These 'wrong' values will be interpreted correctly. Not really a problem.
Created attachment 72198 [details] [review] Bug 20075: Adjust installer files for de-DE up to pl-PL We are replacing the values -5 or 8 here by 1 for the hidden field in auth_subfield_structure. Note that 1 is mainly used in MARC21 and -5 in UNIMARC. Since it is a boolean, I choose here for keeping 0 and 1. The value 8 was only used for field 942 in MARC21 files. The value -5 was replaced in en/marcflavour/unimarc/mandatory/authorities_normal_unimarc.sql it-IT/marcflavour/unimarc/necessari/authority_framework.sql pl-PL/marcflavour/unimarc/mandatory/authorities_normal_unimarc.sql NOTE: The french unimarc files fr-FR/marcflavour/unimarc_complet/Obligatoire/autorite_default.sql fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/autorites_norme_unimarc.sql seem to display all fields, since hidden is 0 everywhere. Test plan: Test a new install in one of the languages. Or run the sql script on an empty database.
Created attachment 72199 [details] [review] Bug 20075: Update installer files for ru-RU Instead of the very laborious task of going thru all these files line by line, I am adding a statement at the very end to correct hidden values. Test plan: Run a new Russian install or run a few files on an empty database.
Created attachment 72200 [details] [review] Bug 20075: Update installer files for uk-UA Instead of the very laborious task of going thru all these files line by line, I am adding a statement at the very end to correct hidden values. Test plan: Run a new Ukrainian install or run a few files on an empty database.
Created attachment 72201 [details] [review] Bug 20075: Replace hidden -5 by 1 in data and interface In the preceding patches we chose for 1 instead of -5. The interface should move that direction too obviously. Test plan: Test toggling between Show all and Hide all in the auth frameworks. Run the db rev.
Comment on attachment 72201 [details] [review] Bug 20075: Replace hidden -5 by 1 in data and interface Moved to 20074
Pushed to master for 18.05 to have it along with bug 20074. Thanks Marcel!