Bug 20161 - Show same information for format, material type etc. on the detail page as in the result list
Summary: Show same information for format, material type etc. on the detail page as in...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-08 10:10 UTC by Katrin Fischer
Modified: 2022-03-07 14:39 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20161: add format, material type, etc to staff details page (33.42 KB, patch)
2022-03-02 19:19 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 20161: add format, material type, etc to staff/OPAC details page (73.85 KB, patch)
2022-03-02 21:48 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-02-08 10:10:43 UTC
A lot of libraries ask, why there is less information about the material type, format and literary format shown on the detail page than in the result list. 

I suggest to match both displays and make it possible to hide with CSS as you can already do on the result list (using the same classes).
Comment 1 Lucas Gass 2022-03-02 19:19:49 UTC
Created attachment 131294 [details] [review]
Bug 20161: add format, material type, etc to staff details page

1. Make sure DisplayIconsXSLT is on.
2. Look at the results page from the staff client.
3. Notice the results_material_type contains 'Material type', 'Format', 'Literary form', 'Type of visual material'
4. Look at the staff detail page and notice that only 'Material type' will show.
5. Apply patch and restart everything
6. Now look at the detail page and it should match what you see on the results page.
7. Turn off DisplayIconsXSLT
8. Make sure nothing on the results_material_type now displays.
Comment 2 Lucas Gass 2022-03-02 19:22:04 UTC
This first patch deals with the staff client. A second one to deal with the OPAC will be incoming ASAP.
Comment 3 Lucas Gass 2022-03-02 21:48:41 UTC
Created attachment 131303 [details] [review]
Bug 20161: add format, material type, etc to staff/OPAC details page

For staff side:
1. Make sure DisplayIconsXSLT is on.
2. Look at the results page from the staff client.
3. Notice the results_material_type contains 'Material type', 'Format', 'Literary form', 'Type of visual material'
4. Look at the staff detail page and notice that only 'Material type' will show.
5. Apply patch and restart everything
6. Now look at the detail page and it should match what you see on the results page.
7. Turn off DisplayIconsXSLT
8. Make sure nothing on the results_material_type now displays.

For OPAC:
1. Make sure DisplayOPACiconsXSLT is on.
2. Look at the results page from the OPAC.
3. Notice the results_material_type contains 'Material type', 'Format', 'Literary form', 'Type of visual material'
4. Look at the OPAC detail page and notice that only 'Material type' will show.
5. Apply patch and restart everything
6. Now look at the detail page and it should match what you see on the results page.
7. Turn off DisplayOPACiconsXSLT
8. Make sure nothing on the results_material_type now displays.
Comment 4 Katrin Fischer 2022-03-06 12:48:00 UTC
Hi Lucas, 

if we want to display the same information everywhere, maybe a new include file (like for the languages) would be a good idea? It would save some copy and paste and make it easier to keep things aligned in the future.

If we make it a template, it would also be easy to pass on some specifics like different class names.

What do you think?
Comment 5 Lucas Gass 2022-03-07 14:39:24 UTC
(In reply to Katrin Fischer from comment #4)
> Hi Lucas, 
> 
> if we want to display the same information everywhere, maybe a new include
> file (like for the languages) would be a good idea? It would save some copy
> and paste and make it easier to keep things aligned in the future.
> 
> If we make it a template, it would also be easy to pass on some specifics
> like different class names.
> 
> What do you think?

I was curious about this, it is A LOT of repeated code. I think it's a good idea and I'll mark this one as FQA now because of that.