We have two similer patron menus in templates, almost everywhere is used circ-menu.inc. Only when editing patron record, the members-menu.inc is used. It means the menu items are not compete, because members-menu is not synchronized with updates of circ-menu. There is also reference to members-menu in member.tt template (the template used in patron search ) which is probably never taken into effect.
Created attachment 76575 [details] [review] Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none.
Created attachment 78411 [details] [review] Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none.
Created attachment 78647 [details] [review] Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. Michal Denar Signed-off-by: <black23@gmail.com>
Created attachment 79261 [details] [review] Bug 20223: Merge members-menu and circ-menu inc files This patch removes members-menu.inc and replaces the last functional use of it with a call to circ-menu.inc. An invalid use of members-menu.inc has been removed from member.tt. To test, apply the patch and open a patron record for editing. The sidebar menu should look correct and all sidebar links should work correctly. View the patrons home page and confirm that nothing has broken. Search the Koha codebase for references to members-menu.inc. There should be none. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Changing to bugfix.
Found bug 21397 while testing.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Depends on Bug 18789 not in 17.11.x