Bug 20302 - Allow translating Delete button in Patron batch mod tool
Summary: Allow translating Delete button in Patron batch mod tool
Status: Pushed to Stable
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-27 11:10 UTC by paxed
Modified: 2018-04-06 17:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20302: Allow translating Delete button in Patron batch (1.96 KB, patch)
2018-02-27 11:11 UTC, paxed
Details | Diff | Splinter Review
Bug 20302: Allow translating Delete button in Patron batch mod tool (2.03 KB, patch)
2018-02-27 16:59 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-02-27 11:10:10 UTC
There is an untranslatable Delete-button in the patron batch modification tool.
Comment 1 paxed 2018-02-27 11:11:47 UTC
Created attachment 72254 [details] [review]
Bug 20302: Allow translating Delete button in Patron batch

There is an untranslatable Delete-button in the patron batch modification
tool. Allow translating it.

Test plan:

1) Go to Home -> Tools -> Batch patron modification, put a patron's
   card number in the box, and click on Continue
2) At the bottom of the screen there is an drop-down entry for
   Attribute, click on the "New" at the nd of that line
3) There should now be another Attribute -line, with "Delete" -link
   at the end of that line
4) Apply patch, install a language
5) Repeat 1-3 in that language, the Delete-link should be shown in
   the correct language, if the msgid "Delete" was translated
   in xx-YY-staff-prog.po
Comment 2 Jonathan Druart 2018-02-27 16:59:15 UTC
Created attachment 72279 [details] [review]
Bug 20302: Allow translating Delete button in Patron batch mod tool

There is an untranslatable Delete-button in the patron batch modification
tool. Allow translating it.

Test plan:

1) Go to Home -> Tools -> Batch patron modification, put a patron's
   card number in the box, and click on Continue
2) At the bottom of the screen there is an drop-down entry for
   Attribute, click on the "New" at the nd of that line
3) There should now be another Attribute -line, with "Delete" -link
   at the end of that line
4) Apply patch, install a language
5) Repeat 1-3 in that language, the Delete-link should be shown in
   the correct language, if the msgid "Delete" was translated
   in xx-YY-staff-prog.po

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2018-02-27 16:59:46 UTC
Trivial, skipping QA.
Comment 4 Jonathan Druart 2018-02-27 19:00:00 UTC
Pushed to master for 18.05, thanks to everybody involved!
Comment 5 Nick Clemens 2018-04-06 17:47:31 UTC
Awesome work all, backported to stable for 17.11.05