Since bug 19996 we have now warnings in cataloguing scripts.
Created attachment 72271 [details] [review] Bug 20304: Remove warnings from cataloguing scripts
Created attachment 72272 [details] [review] Bug 20304: Remove warnings from cataloguing scripts
I am going to attach patches when I find these warnings.
Comment on attachment 72272 [details] [review] Bug 20304: Remove warnings from cataloguing scripts Review of attachment 72272 [details] [review]: ----------------------------------------------------------------- ::: cataloguing/additem.pl @@ +157,5 @@ > my $temp2 = $temp->field($CNtag); > if ($temp2) { > + my $value = q{}; > + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield); > + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2); Where's the space gone?
Created attachment 73522 [details] [review] Bug 20304: Remove warnings from cataloguing scripts
(In reply to M. Tompsett from comment #4) > Comment on attachment 72272 [details] [review] [review] > Bug 20304: Remove warnings from cataloguing scripts > > Review of attachment 72272 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: cataloguing/additem.pl > @@ +157,5 @@ > > my $temp2 = $temp->field($CNtag); > > if ($temp2) { > > + my $value = q{}; > > + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield); > > + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2); > > Where's the space gone? lost, but I found it!
Created attachment 73869 [details] [review] Bug 20304: Remove warnings from cataloguing scripts
Set a default value for the holding branch in the default framework. Add a manual record using the default framework. In order to trigger all the code, I needed a value in 082$a I then put crazy long values (>100) in text fields for the item and saved. I made sure the full call number was set to something (I used 100$ab). So yes, my data is horrible, but having triggered all the code, I know it works. :) And so much less floody.
Created attachment 73961 [details] [review] Bug 20304: Remove warnings from cataloguing scripts Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 74876 [details] [review] Bug 20304: Remove warnings from cataloguing scripts Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 74877 [details] [review] Bug 20304: (QA follow-up) Remove unwanted 'my' 'my' creates a new '$value' variable, and prevented the '$value' in outer scope to be modified Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 18.05, thanks to everybody involved!