Bug 20356 - Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address
Summary: Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Gustafsson
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-07 16:58 UTC by David Gustafsson
Modified: 2023-10-04 13:01 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20356 - Add EmailSMSSendDriverFromAddress system preference (6.65 KB, patch)
2018-03-07 17:02 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 20356: Add EmailSMSSendDriverFromAddress system preference (6.69 KB, patch)
2018-03-07 17:05 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 20356: Add EmailSMSSendDriverFromAddress system preference (6.86 KB, patch)
2018-05-07 12:12 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 20356: Add EmailSMSSendDriverFromAddress system preference (6.84 KB, patch)
2018-10-01 12:50 UTC, David Gustafsson
Details | Diff | Splinter Review
Bug 20356: Add EmailSMSSendDriverFromAddress system preference (6.86 KB, patch)
2018-10-01 18:50 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 20356: Add EmailSMSSendDriverFromAddress system preference (6.96 KB, patch)
2018-11-02 10:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2018-03-07 16:58:40 UTC
Our SMS gateway provider requires that only one specific email address is used in as sender for all emails. This patch adds a system preference for setting "from" address for all mails sent by the Email SMS send driver.
Comment 1 David Gustafsson 2018-03-07 17:02:23 UTC
Created attachment 72517 [details] [review]
Bug 20356 - Add EmailSMSSendDriverFromAddress system preference

Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.

How to test:

1. Run tests in t/db_dependent/Letters.t
2. All tests should pass
Comment 2 David Gustafsson 2018-03-07 17:05:03 UTC
Created attachment 72518 [details] [review]
Bug 20356: Add EmailSMSSendDriverFromAddress system preference

Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.

How to test:
1) Run tests in t/db_dependent/Letters.t
2) All tests should pass

Sponsored-by: Gothenburg University Library
Comment 3 David Gustafsson 2018-05-07 12:12:19 UTC
Created attachment 75111 [details] [review]
Bug 20356: Add EmailSMSSendDriverFromAddress system preference

Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.

How to test:
1) Run tests in t/db_dependent/Letters.t
2) All tests should pass

Sponsored-by: Gothenburg University Library
Comment 4 David Gustafsson 2018-05-07 12:12:39 UTC
Rebased against Koha master.
Comment 5 Michal Denar 2018-10-01 12:31:56 UTC
Please rebase on master, I'll test it.
Comment 6 David Gustafsson 2018-10-01 12:50:11 UTC
Created attachment 79712 [details] [review]
Bug 20356: Add EmailSMSSendDriverFromAddress system preference

Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.

How to test:
1) Run tests in t/db_dependent/Letters.t
2) All tests should pass

Sponsored-by: Gothenburg University Library
Comment 7 Michal Denar 2018-10-01 18:50:10 UTC
Created attachment 79760 [details] [review]
Bug 20356: Add EmailSMSSendDriverFromAddress system preference

Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.

How to test:
1) Run tests in t/db_dependent/Letters.t
2) All tests should pass

Sponsored-by: Gothenburg University Library

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 8 Jonathan Druart 2018-10-02 12:18:38 UTC
Should not it be defined at provider level instead (table sms_providers)?
Just asking ;)
Comment 9 David Gustafsson 2018-10-02 12:40:54 UTC
Yes, I agree that would probably be better. I think I made just the minimal effort to fix the problem (for us) and thought that I might refactor this later to add the setting on provider level. Could set this to "needs work" and I might fix this later, or if any one else have the time to do so.
Comment 10 Jonathan Druart 2018-10-02 14:51:55 UTC
The things is that it would be done later, but will require more work (remove the code, update the DB, etc.)
Not a big deal anyway.
I will let the status as "Needs QA" to let another QAer give their opinion.
Comment 11 Jonathan Druart 2018-10-02 14:52:21 UTC
*could* be done
Comment 12 Josef Moravec 2018-10-12 12:43:44 UTC
(In reply to Jonathan Druart from comment #10)
> The things is that it would be done later, but will require more work
> (remove the code, update the DB, etc.)
> Not a big deal anyway.
> I will let the status as "Needs QA" to let another QAer give their opinion.

As this is required by specific provider, it should be done on provider level I think.
Comment 13 Marcel de Rooy 2018-11-02 10:40:07 UTC
Created attachment 81875 [details] [review]
Bug 20356: Add EmailSMSSendDriverFromAddress system preference

Add EmailSMSSendDriverFromAddress system preference for overriding Email
SMS send driver from address.

How to test:
1) Run tests in t/db_dependent/Letters.t
2) All tests should pass

Sponsored-by: Gothenburg University Library

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 14 Marcel de Rooy 2018-11-02 10:41:03 UTC
Not a blocker for me.
Very specific and small issue, easy to move to provider db on a new report. Please open one, David.
Passed QA
Comment 15 Nick Clemens 2018-11-13 16:37:48 UTC
Awesome work all!

Pushed to master for 18.11
Comment 16 Martin Renvoize 2018-11-16 14:23:31 UTC
Enhancement, will not be backported to 18.05.x series.