The encoded languages from MARC21 field 041 are not shown anywhere. These are quite important for example DVD video material (subtitle languages).
Created attachment 72559 [details] [review] Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3
Created attachment 73363 [details] [review] Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Created attachment 73364 [details] [review] Bug 20364: Follow up to correct koha qa test tool failure Plus, improve the perlcritic level beyond minimal. TEST PLAN --------- 1) apply first patch 2) run the script in a koha shell output to before.xml 3) run koha qa test tools -- script will fail. 4) perlcritic -3 on script is noisy. 5) apply this patch 6) run the script in a koha shell output to after.xml 7) a diff of these two output files should be identical 8) run koha qa test tools -- script will now pass 9) perlcritic -3 on script is OK.
Created attachment 79858 [details] [review] Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Incorporated the QA fixes by M. Tompsett in this patch. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3
Patch doesn't apply. The patch seems to erase all the record information in the Normal view tab. Title, author and contributor names, publisher, material type, description and other fields all disappear. Only the item information is displayed on screen (item, call number, status, location and barcode).
Created attachment 90347 [details] [review] Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3
Adding Marcel to the CC list as my 'go to xslt guy'. Changes look sound to me so far.
Created attachment 90845 [details] [review] Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 91394 [details] [review] Bug 20364: Show languages from MARC21 field 041 in intranet Show the language names coded in field 041, in intranet search results and in detail view. Test plan: 1) Apply patch 2) Do a search, and check the results look correct 3) Check some biblio detail pages that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I am not totally fond of the ending . on the fields, but as there can be multiple labels on the same line, I can see why they were put there. Something to work later maybe. Also: There is no mention of the maintenance script in the commit message. Wondering how we can document this best.
Nice work! Pushed to master for 19.11.00
Enhancement not pushed to 19.05.x