Bug 20442 - Use more HtmlTags filter
Summary: Use more HtmlTags filter
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-19 08:07 UTC by paxed
Modified: 2022-03-23 01:12 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20442: intranet patron clubs (7.52 KB, patch)
2018-03-19 08:10 UTC, paxed
Details | Diff | Splinter Review
Bug 20442: intranet catalogue (10.39 KB, patch)
2018-03-19 09:51 UTC, paxed
Details | Diff | Splinter Review
Bug 20442: Use more HtmlTags filter (10.52 KB, patch)
2018-04-09 05:14 UTC, Dilan Johnpullé
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2018-03-19 08:07:53 UTC
Some strings are hard to translate, because there are HTML tags splitting the sentences into multiple parts. Use the HtmlTags filter so the sentences can be translated as a single unit instead.
Comment 1 paxed 2018-03-19 08:10:06 UTC
Created attachment 73082 [details] [review]
Bug 20442: intranet patron clubs

Some strings are hard to translate, because there are HTML tags splitting
the sentences into multiple parts. Use the HtmlTags filter so the sentences
can be translated as a single unit instead.

This is the intranet Patron clubs part.

Test plan:
1) Apply patch
2) Go to Home -> Tools -> Patron clubs
3) Create a new template, edit it, a new club, edit it, etc.
4) Note the strings look correct in the page
5) Update a language po-files
6) Look through the xx-YY-staff-prog.po for the clubs pages
   strings and that they look correct
Comment 2 paxed 2018-03-19 09:51:03 UTC
Created attachment 73088 [details] [review]
Bug 20442: intranet catalogue

Some strings are hard to translate, because there are HTML tags splitting
the sentences into multiple parts. Use the HtmlTags filter so the sentences
can be translated as a single unit instead.

This is the intranet catalogue part.

Test plan:
1) Apply patch
2) Search for a biblio
3) See the "X result(s) found for ..." that it looks correct
4) Check out the biblio detail page and MARC detail page breadcrumbs
5) Search for nonexistent biblio, check the "No results match for ..." text
6) Update a language po-files
7) Look through the xx-YY-staff-prog.po for the catalogue pages
   strings and that they look correct
Comment 3 paxed 2018-03-19 12:55:34 UTC
There's more room for improvement than just these, but I don't have time to work on it right now. This is a good start at least.
Comment 4 Dilan Johnpullé 2018-04-09 05:14:54 UTC
Created attachment 73842 [details] [review]
Bug 20442: Use more HtmlTags filter

Some strings are hard to translate, because there are HTML tags splitting
the sentences into multiple parts. Use the HtmlTags filter so the sentences
can be translated as a single unit instead.

This is the intranet catalogue part.

Test plan:
1) Apply patch
2) Search for a biblio
3) See the "X result(s) found for ..." that it looks correct
4) Check out the biblio detail page and MARC detail page breadcrumbs
5) Search for nonexistent biblio, check the "No results match for ..." text
6) Update a language po-files
7) Look through the xx-YY-staff-prog.po for the catalogue pages
   strings and that they look correct

Patch applies and functions as expected.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 5 Katrin Fischer 2018-04-18 06:15:36 UTC
Sorry paxed patches don't apply. Can you please rebase?
Comment 6 Fridolin Somers 2022-03-23 01:12:19 UTC
Note that we also have KohaSpan using id and class.
In my opinion, this should be use to allow tuning via CSS.