The record that get passed to ModBiblioMarc will not have items embedded. Saving this through ModZebra will create an elastic document without items, and no items will be shown in search results for example. By removing the $record argument from the ModZebra call, ModZebra will reload the record with items embedded, which solves the problem.
Created attachment 73755 [details] [review] Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results.
Created attachment 82844 [details] [review] Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results.
Rebased against master.
Created attachment 85890 [details] [review] Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 86083 [details] [review] Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Maybe we should remove this parameter from ModZebra? And improve ModZebra in that case, it calls GetMarcBiblio without testing $server. (On a separate bug report of course)
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
not backporting to 18.05.x