In the ILL intranet controller, the authnotrequired flag is not explicitly unset in get_template_and_user and as such if a user attempts to navigate directly to any of the ILL forms they are faced with an error rather than the standard login redirect.
Created attachment 73757 [details] [review] Bug 20536 - ILL: authnotrequired not explicitly unset * ill/illrequest.pl - Added explicity setting of authnotrequired
I enabled IllModule system preference. Went to Home -> ILL Requests (didn't get forced log in screen, though I got configuration warning note) Copied URL. Logged out. Pasted URL into address bar. Got forced login screen. It seems like overkill, given that: 157 sub get_template_and_user { 158 159 my $in = shift; 160 my ( $user, $cookie, $sessionID, $flags ); 161 162 C4::Context->interface( $in->{type} ); 163 164 $in->{'authnotrequired'} ||= 0; 165 In C4/Auth.pm it expressly gets set if it isn't passed. So unless you can provide a set of steps as explicit as this which repeats the problem, I am marking this RESOLVED WORKSFORME.
Ack, you're totally right.. it's the OPAC side I meant to patch not the staff client!
Created attachment 73846 [details] [review] Bug 20536 - ILL: authnotrequired should be explicitly unset on opac * koha/opac-illrequest.pl - Added explicit setting of authnotrequired
Created attachment 73847 [details] [review] Bug 20536 - ILL: authnotrequired should be explicitly unset on opac * koha/opac-illrequest.pl - Added explicit setting of authnotrequired
(In reply to Martin Renvoize from comment #0) > if a user attempts to navigate > directly to any of the ILL forms they are faced with an error rather than > the standard login redirect. Aaaah! That's the problem... okay, got it. Reproduced. YAY!
When OpacPublic is Enabled, going directly to http://kohadev.mydnsname.org/cgi-bin/koha/opac-illrequests.pl on a kohadevbox doesn't give the log in, but rather attempts to show the page. It should always require log in for ILL requests.
Created attachment 73898 [details] [review] Bug 20536 - ILL: authnotrequired should be explicitly unset on opac * koha/opac-illrequest.pl - Added explicit setting of authnotrequired Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 73917 [details] [review] Bug 20536: (ILL) authnotrequired should be explicitly unset on opac * koha/opac-illrequest.pl - Added explicit setting of authnotrequired Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 18.05, thanks to everybody involved!
Pushed to stbale for 17.11.06 Awesome work all!
Depends on Bug 7317 not in 17.05.x