Bug 20558 - typo mts_authorized_value vs mts_authorised_value in admin/marctagstructure.pl
Summary: typo mts_authorized_value vs mts_authorised_value in admin/marctagstructure.pl
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-10 17:58 UTC by Jonathan Druart
Modified: 2022-10-17 08:13 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-04-10 17:58:13 UTC
What are the consequences of this?
Comment 1 Marcel de Rooy 2022-09-15 09:30:26 UTC
(In reply to Jonathan Druart from comment #0)
> What are the consequences of this?

There are no consequences. This is dead code.

There are several issues here:
[1] We should not allow to edit an authorised value to a field higher than 010 in MARC21. That make no sense !
[2] The template does not make a distinction between control fields lower than 010 and other ones.
Look e.g. here:
<span>Tab:[% subfield.tab | html %]</span> | $[% subfield.tagsubfield | html %]
[% subfield.liblibrarian | html %] [% IF ( subfield.kohafield ) %][% subfield.kohafield | html %][% END %][% IF ( subfield.repeatable ) %], <span>repeatable</span>[% END %][% IF ( subfield.mandatory ) %], <span>Mandatory</span>[% END %][% IF ( subfield.seealso ) %], <span>See [% subfield.seealso | html %]</span>[% END %][% IF ( subfield.authorised_value ) %], [% subfield.authorised_value | html %][% END %][% IF ( subfield.authtypecode ) %], [% subfield.authtypecode | html %][% END %][% IF ( subfield.value_builder ) %], [% subfield.value_builder | html %][% END %]

If a subfield has an AV it is listed, but if a controlfield<10 has one, it is not listed.
Comment 2 Jonathan Druart 2022-10-17 08:13:02 UTC
(In reply to Marcel de Rooy from comment #1)
> (In reply to Jonathan Druart from comment #0)
> > What are the consequences of this?
> 
> There are no consequences. This is dead code.

Are you sure?

Didn't investigate much, only using git grep


admin/marctagstructure.pl:                    marc_tag_structure.authorised_value as mts_authorized_value,

admin/marctagstructure.pl:          $row_data{authorised_value} = $results[$i]->{'mts_authorised_value'};

koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt:            <td>[% loo.authorised_value | html %]</td>