Created attachment 74122 [details] [review]
WR: 289187 - Script to loop through catalog removing 998 tag data
this appears to be very specific, as 998 is a user defined custom field. Can you explain the use case?
Yes I think you're right this patch is not upstreamable as it is too specific.
The use case that prompted me to write this script is that one of our clients had migrated data across to Koha, and in this migrated data the marcxml contained barcodes in the 998$a MARC subfield.
As the 998 MARC field is not updated when moving an item from one biblio to another the old biblio (as well as the new biblio) continued to be displayed in search results for the moved items barcode.
Therefore running this script to remove the 998 field stopped this indexing bug from happening. This script could be useful if it was made more generic so a MARC subfield in migrated data could be specified to be removed where it is not necessary or it is causing indexing errors. However I will park this at the moment.
A patch that would be useful to get your feedback on is https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 which is fixing the broken patron filtering on the patron page in the intranet as that is quite a major bug.