Internal server errror on clicking New category in Admin/Patron categories Template process failed: undef error - Can't call method "p_sep_by_space" on an undefined value at /usr/share/koha/devclone/Koha/Number/Price.pm line 126. Sub _format_params assumes that there is an active currency. (Which was not there yet in a new installed system.) Since we are showing an empty page here, I do not see the need of a currency for just formatting a zero or null value ??
Maybe add the currency selection into the onboarder, before you add a patron category (if the "currency" sample data isn't selected)
Caused by commit 18e72e31957a51206875ac27d92929909a90ef34 Bug 4078: Add the ability to display and configure the symbol for prices
Created attachment 74737 [details] [review] Bug 20625: Add tests
Created attachment 74738 [details] [review] Bug 20625: Handle non existing of active currency This patch avoid the explosion in the air when creating a new patron category and no active currency is defined. Test plan: Remove the currencies, create a new patron category Without this patch applied you will get Can't call method "p_sep_by_space" on an undefined value With this patch the form will be displayed correctly and you will be able to create the patron category
Created attachment 74740 [details] [review] Bug 20625: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 74741 [details] [review] Bug 20625: Handle non existing of active currency This patch avoid the explosion in the air when creating a new patron category and no active currency is defined. Test plan: Remove the currencies, create a new patron category Without this patch applied you will get Can't call method "p_sep_by_space" on an undefined value With this patch the form will be displayed correctly and you will be able to create the patron category Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Test only applied, kaboom. With patch, no kaboom. And code change eyeballs well.
Created attachment 74774 [details] [review] Bug 20625: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 74775 [details] [review] Bug 20625: Handle non existing of active currency This patch avoid the explosion in the air when creating a new patron category and no active currency is defined. Test plan: Remove the currencies, create a new patron category Without this patch applied you will get Can't call method "p_sep_by_space" on an undefined value With this patch the form will be displayed correctly and you will be able to create the patron category Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!