Bug 20639 - Allow setting a default/single backend for OPAC driven requests
Summary: Allow setting a default/single backend for OPAC driven requests
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Andrew Isherwood
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 20581
Blocks: 20750
  Show dependency treegraph
 
Reported: 2018-04-23 15:47 UTC by Martin Renvoize
Modified: 2018-11-01 11:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20639: Add ILLOpacbackends syspref (4.84 KB, patch)
2018-04-24 13:17 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 20639: Add ILLOpacbackends syspref (4.84 KB, patch)
2018-04-24 13:57 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 20639: Add ILLOpacbackends syspref (5.07 KB, patch)
2018-05-08 15:18 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20639: Add ILLOpacbackends syspref (5.07 KB, patch)
2018-08-24 09:16 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20639: (follow-up) Fix variable not passed (2.49 KB, patch)
2018-09-17 14:11 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20639: (follow-up) Fix population of backends (1.34 KB, patch)
2018-09-27 10:49 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20639: Add ILLOpacbackends syspref (5.12 KB, patch)
2018-09-27 11:19 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 20639: (follow-up) Fix population of backends (1.39 KB, patch)
2018-09-27 11:19 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-04-23 15:47:38 UTC
If you have more than one ILL backend installed, and OPAC ILL Requests enabled the OPAC users are currently faced with a dropdown list of backends to start a request on. This is often meaningless to the end user and as such a default should be configurable at the least and preferably the ability to set a fast path to only allow a prefered backend to be used from the OPAC.
Comment 1 Martin Renvoize 2018-04-24 13:17:23 UTC
Created attachment 74806 [details] [review]
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests
Comment 2 Martin Renvoize 2018-04-24 13:57:04 UTC
Created attachment 74811 [details] [review]
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests
Comment 3 Andrew Isherwood 2018-05-08 15:17:46 UTC
Comment on attachment 74811 [details] [review]
Bug 20639: Add ILLOpacbackends syspref

Obsoleted due to updated patch
Comment 4 Andrew Isherwood 2018-05-08 15:18:33 UTC
Created attachment 75165 [details] [review]
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference
Comment 5 Andrew Isherwood 2018-08-24 09:16:56 UTC
Created attachment 78119 [details] [review]
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference
Comment 6 Andrew Isherwood 2018-09-17 14:11:55 UTC
Created attachment 79033 [details] [review]
Bug 20639: (follow-up) Fix variable not passed

available_backends expects a variable declaring the contents
of the ILLopacbackends syspref. This wasn't being passed in all calls to
it, so I've removed the requirement for it being passed, we now check
the contents of the syspref in available_backends itselfBug
Comment 7 Andrew Isherwood 2018-09-17 14:23:01 UTC
To test:

1. Ensure you have at least two ILL backends installed
2. From the OPAC user's home page, choose "your interlibrary loan requests"
3. Click the "Create a new request" button
4. TEST: Observe that all backends are available
5. As a user with sufficient privileges, go to the System Preferences
6. Search the privileges for "interlibrary"
7. TEST: Observe that a "ILLOpacbackends" preference is available
8. Enter the name of *one* of the installed backends in the input box for "ILLOpacbackends", for example BLDSS
9. From the OPAC user's home page, choose "your interlibrary loan requests"
10. TEST: Observe that the "Create a new request" button is no longer a select box
11. TEST: Observe that clicking the "Create a new request" button takes you straight to the form for creating a request with the single available backend
12. As a user with sufficient privileges, go to the System Preferences
13. Search the privileges for "interlibrary"
14. Enter the name of *two* of the installed backends in the input box for "ILLOpacbackends", separated by a | character for example: BLDSS|Koha
15. From the OPAC user's home page, choose "your interlibrary loan requests"
16. TEST: Observe that the "Create a new request" button is now a select box
17. TEST: Observe that clicking the "Create a new request" button only offers the backends specified in step 14
Comment 8 Andrew Isherwood 2018-09-27 10:49:06 UTC
Created attachment 79474 [details] [review]
Bug 20639: (follow-up) Fix population of backends

The OPAC view wasn't correctly restricting the display of backends when
the ILLOpacbackends preference was set.

See the test plan on comment 7
Comment 9 PTFS Europe Sandboxes 2018-09-27 11:19:17 UTC
Created attachment 79477 [details] [review]
Bug 20639: Add ILLOpacbackends syspref

This adds the ILLOpacbackends syspref, allowing users to refine the ill
backends available to opac users for initiating ill requests

Remove default assignment for backends

We don't need a default assignment for the ILLOpacbackends assignment,
if the pref isn't set, it returns undef anyway. Also, having this
default assignment actually breaks the fetching of the preference

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
Comment 10 PTFS Europe Sandboxes 2018-09-27 11:19:40 UTC
Created attachment 79478 [details] [review]
Bug 20639: (follow-up) Fix population of backends

The OPAC view wasn't correctly restricting the display of backends when
the ILLOpacbackends preference was set.

See the test plan on comment 7

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie