Bug 20663 - Dead report code for "Create Compound Report" since prior to 3.0.x
Summary: Dead report code for "Create Compound Report" since prior to 3.0.x
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: M. Tompsett
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-26 04:06 UTC by M. Tompsett
Modified: 2018-05-04 12:50 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20663: Remove dead code related to compound reports (4.70 KB, patch)
2018-04-26 04:34 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 20663: Add some POD, so koha test tools don't complain (728 bytes, patch)
2018-04-26 04:34 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 20663: Remove dead code related to compound reports (4.78 KB, patch)
2018-04-29 22:31 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20663: Add some POD, so koha test tools don't complain (792 bytes, patch)
2018-04-29 22:31 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20663: Remove dead code related to compound reports (4.85 KB, patch)
2018-05-04 09:36 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 20663: Add some POD, so koha test tools don't complain (883 bytes, patch)
2018-05-04 09:36 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description M. Tompsett 2018-04-26 04:06:03 UTC
git grep "Create Compound Report"
only generates one matching line in guided reports. It makes no sense to keep this dead code and the code which it would trigger.
Comment 1 M. Tompsett 2018-04-26 04:34:23 UTC
Created attachment 74871 [details] [review]
Bug 20663: Remove dead code related to compound reports

TEST PLAN
---------
git grep "Create Compound Report"
-- only one file
git grep compound | grep 1
-- this is the only setting of the compound tt variable
less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
-- There is an TT IF statement for compound.
-- In that statement it would trigger 'Save Compound'
git grep save_compound
-- only the template and the guided report perl
git grep create_compound
-- only triggered by the save code in the guided report perl
-- in the export for the C4/Reports/Guided.pm
git grep run_compound
-- left over in export

apply the patch
look around and see the pieces are cleaned up.

run koha qa test tools
Comment 2 M. Tompsett 2018-04-26 04:34:25 UTC
Created attachment 74872 [details] [review]
Bug 20663: Add some POD, so koha test tools don't complain
Comment 3 Katrin Fischer 2018-04-29 22:31:01 UTC
Created attachment 74925 [details] [review]
Bug 20663: Remove dead code related to compound reports

TEST PLAN
---------
git grep "Create Compound Report"
-- only one file
git grep compound | grep 1
-- this is the only setting of the compound tt variable
less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
-- There is an TT IF statement for compound.
-- In that statement it would trigger 'Save Compound'
git grep save_compound
-- only the template and the guided report perl
git grep create_compound
-- only triggered by the save code in the guided report perl
-- in the export for the C4/Reports/Guided.pm
git grep run_compound
-- left over in export

apply the patch
look around and see the pieces are cleaned up.

run koha qa test tools

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2018-04-29 22:31:04 UTC
Created attachment 74926 [details] [review]
Bug 20663: Add some POD, so koha test tools don't complain

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Frédéric Demians 2018-04-30 16:51:21 UTC
Isn't this patch supposed to have the Signed-off status?
Comment 6 Katrin Fischer 2018-04-30 16:53:47 UTC
Correct, thx Frederic.
Comment 7 Marcel de Rooy 2018-05-04 09:36:28 UTC
Created attachment 75055 [details] [review]
Bug 20663: Remove dead code related to compound reports

TEST PLAN
---------
git grep "Create Compound Report"
-- only one file
git grep compound | grep 1
-- this is the only setting of the compound tt variable
less koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
-- There is an TT IF statement for compound.
-- In that statement it would trigger 'Save Compound'
git grep save_compound
-- only the template and the guided report perl
git grep create_compound
-- only triggered by the save code in the guided report perl
-- in the export for the C4/Reports/Guided.pm
git grep run_compound
-- left over in export

apply the patch
look around and see the pieces are cleaned up.

run koha qa test tools

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2018-05-04 09:36:32 UTC
Created attachment 75056 [details] [review]
Bug 20663: Add some POD, so koha test tools don't complain

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Jonathan Druart 2018-05-04 12:49:45 UTC
Dead since
  commit 68ce64a793b023164ac19a56602747945a1bdca1
  Date:   Mon Oct 29 13:19:58 2007 -0500
    Bugfixing the template, and removing link to compound reports
Comment 10 Jonathan Druart 2018-05-04 12:50:35 UTC
Pushed to master for 18.05, thanks to everybody involved!