Clicking "Details" on a list of a patron's fines and payments (http://localhost:8081/cgi-bin/koha/members/boraccount.pl?borrowernumber=##) results in a Error 500 when plack is turned off.
Created attachment 74887 [details] [review] Bug 20666: Correct executable permissions TEST PLAN --------- On a kohadevbox: 1) sudo koha-plack --enable kohadev 2) restart_all 3) Enter fines for a patron in the staff client 4) Go to the 'Fines' tab (left pane) 5) Go to the 'Account' tab (below the row of buttons) 6) Click 'Details' -- no issues 7) sudo koha-plack --disable kohadev 8) restart_all 9) refresh page -- Error 500 10) apply patch 11) restart_all 12) refresh page -- no issues 13) sudo koha-plack --enable kohadev 14) restart_all 15) refresh page -- no issues
find . -name "*.pl" -type f ! -executable I believe the only other one that matters in opac/opac-routing-lists.pl I finally got the routing list tab to appear in OPAC and confirmed.
Created attachment 74888 [details] [review] Bug 20666: Correct permissions on opac-routing-lists.pl You will need to have the 'Your routing lists' appear in the opac-user page in order to trigger the error. Make sure plack is off, and you will get an error 500 page.
Created attachment 74923 [details] [review] Bug 20666: Correct executable permissions TEST PLAN --------- On a kohadevbox: 1) sudo koha-plack --enable kohadev 2) restart_all 3) Enter fines for a patron in the staff client 4) Go to the 'Fines' tab (left pane) 5) Go to the 'Account' tab (below the row of buttons) 6) Click 'Details' -- no issues 7) sudo koha-plack --disable kohadev 8) restart_all 9) refresh page -- Error 500 10) apply patch 11) restart_all 12) refresh page -- no issues 13) sudo koha-plack --enable kohadev 14) restart_all 15) refresh page -- no issues Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74924 [details] [review] Bug 20666: Correct permissions on opac-routing-lists.pl You will need to have the 'Your routing lists' appear in the opac-user page in order to trigger the error. Make sure plack is off, and you will an error 500 page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 74937 [details] [review] Bug 20666: Correct executable permissions TEST PLAN --------- On a kohadevbox: 1) sudo koha-plack --enable kohadev 2) restart_all 3) Enter fines for a patron in the staff client 4) Go to the 'Fines' tab (left pane) 5) Go to the 'Account' tab (below the row of buttons) 6) Click 'Details' -- no issues 7) sudo koha-plack --disable kohadev 8) restart_all 9) refresh page -- Error 500 10) apply patch 11) restart_all 12) refresh page -- no issues 13) sudo koha-plack --enable kohadev 14) restart_all 15) refresh page -- no issues Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 74938 [details] [review] Bug 20666: Correct permissions on opac-routing-lists.pl You will need to have the 'Your routing lists' appear in the opac-user page in order to trigger the error. Make sure plack is off, and you will an error 500 page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Pushed to master for 18.05, thanks to everybody involved!