Bug 20686 - OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled
Summary: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref d...
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Mason James
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-01 01:19 UTC by Mason James
Modified: 2018-05-07 15:26 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
pic 1 (159.08 KB, image/png)
2018-05-01 01:36 UTC, Mason James
Details
pic 2 (101.65 KB, image/png)
2018-05-01 01:39 UTC, Mason James
Details
Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled (1.61 KB, patch)
2018-05-01 01:43 UTC, Mason James
Details | Diff | Splinter Review
Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled (1.79 KB, patch)
2018-05-02 05:06 UTC, Dilan Johnpullé
Details | Diff | Splinter Review
Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled (1.85 KB, patch)
2018-05-04 13:56 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2018-05-01 01:19:45 UTC
more info to come...
Comment 1 Mason James 2018-05-01 01:36:18 UTC
Created attachment 74943 [details]
pic 1
Comment 2 Mason James 2018-05-01 01:39:16 UTC
Created attachment 74944 [details]
pic 2
Comment 3 Mason James 2018-05-01 01:43:11 UTC
Created attachment 74945 [details] [review]
Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled

ps: you will need an active and working overdrive account to test this patch

1/ prepare a koha with overdrive sysprefs set and working
    (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret)

2/ set OverDriveCirculation syspref to 'disable'

3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed
    see pic 1

4/ apply patch

5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good)
    see pic 2
Comment 4 Dilan Johnpullé 2018-05-02 05:06:33 UTC
Created attachment 74963 [details] [review]
Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled

ps: you will need an active and working overdrive account to test this patch

1/ prepare a koha with overdrive sysprefs set and working
    (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret)

2/ set OverDriveCirculation syspref to 'disable'

3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed
    see pic 1

4/ apply patch

5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good)
    see pic 2

Can confirm that bug is replicable and patch applies and functions as described.
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Comment 5 Tomás Cohen Arazi 2018-05-04 13:56:03 UTC
Created attachment 75077 [details] [review]
Bug 20686: OPAC shows 'Login to OverDrive account' with 'OverDriveCirculation' syspref disabled

ps: you will need an active and working overdrive account to test this patch

1/ prepare a koha with overdrive sysprefs set and working
    (OverDriveLibraryID,OverDriveClientKey,OverDriveClientSecret)

2/ set OverDriveCirculation syspref to 'disable'

3/ do an opac search, note the 'Login to OverDrive account' message is incorrectly displayed
    see pic 1

4/ apply patch

5/ do an opac search, note the 'Login to OverDrive account' message is no longer displayed (good)
    see pic 2

Can confirm that bug is replicable and patch applies and functions as described.
Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Jonathan Druart 2018-05-07 15:26:15 UTC
Pushed to master for 18.05, thanks to everybody involved!