Bug 20743 - Update two-column templates with Bootstrap grid: Administration part 7
Summary: Update two-column templates with Bootstrap grid: Administration part 7
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20668 21243
Blocks: 20654 21574
  Show dependency treegraph
 
Reported: 2018-05-09 12:08 UTC by Owen Leonard
Modified: 2019-11-19 16:48 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20743: Update two-column templates with Bootstrap grid: Administration part 7 (36.71 KB, patch)
2018-08-17 14:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20743: Update two-column templates with Bootstrap grid: Administration part 7 (37.78 KB, patch)
2018-08-20 14:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20743: Update two-column templates with Bootstrap grid: Administration part 7 (37.84 KB, patch)
2018-08-21 07:52 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 20743: Update two-column templates with Bootstrap grid: Administration part 7 (37.93 KB, patch)
2018-08-27 20:04 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20743: Remove duplicated line 'See your public page' (1.46 KB, patch)
2018-09-21 11:39 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-05-09 12:08:01 UTC
This patch will convert the last of the administration templates to use the Bootstrap grid:

 - printers.tt
 - searchengine/elasticsearch/mappings.tt
 - smart-rules.tt
 - sms_providers.tt
 - sru_modmapping.tt
 - systempreferences.tt
 - transport-cost-matrix.tt
 - usage_statistics.tt
Comment 1 Owen Leonard 2018-08-17 14:33:57 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2018-08-20 14:20:22 UTC Comment hidden (obsolete)
Comment 3 Claire Gravely 2018-08-21 07:52:17 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2018-08-27 20:04:42 UTC
Created attachment 78198 [details] [review]
Bug 20743: Update two-column templates with Bootstrap grid: Administration part 7

This patch modifies several administration templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Navigate directly to /cgi-bin/koha/admin/printers.pl
   - View and edit printers
 - Administration -> Search engine configuration (or navigate directly
   to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl
 - Administration -> Circulation and fines rules
 - Administration -> SMS cellular providers (enable SMSSendDriver or
   navigate directly to /cgi-bin/koha/admin/sms_providers.pl)
 - Administration -> Z39.50/SRU servers -> New SRU server -> Modify SRU
   search fields mapping
 - Administration -> System preferences -> Local use
   - View and edit local use preferences
 - Administration -> Transport cost matrix
 - With  UsageStats enabled, go to Administration -> Share your usage
   statistics.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Nick Clemens 2018-09-06 17:40:11 UTC
Awesome work all! 

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-09-10 17:24:07 UTC
Enhancement, will not be backported to 18.05.x series.
Comment 7 Jonathan Druart 2018-09-15 17:37:05 UTC
Block 
"See your public page:
You do not have anything public yet." on Home › Administration › Usage statistics appears twice.
Comment 8 Nick Clemens 2018-09-21 11:39:56 UTC
Created attachment 79224 [details] [review]
Bug 20743: Remove duplicated line 'See your public page'
Comment 9 Nick Clemens 2018-09-21 13:50:58 UTC
(In reply to Nick Clemens from comment #8)
> Created attachment 79224 [details] [review] [review]
> Bug 20743: Remove duplicated line 'See your public page'

Followup pushed to master