Bug 20744 - Replace staff client header Koha logo gif with transparent png
Summary: Replace staff client header Koha logo gif with transparent png
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 12:53 UTC by Owen Leonard
Modified: 2019-10-14 19:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20744: Replace staff client header Koha logo gif with transparent png (12.22 KB, patch)
2018-05-09 13:10 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20744: Replace staff client header Koha logo gif with transparent png (12.27 KB, patch)
2018-05-11 06:48 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 20744: Replace staff client header Koha logo gif with transparent png (14.47 KB, patch)
2018-05-28 20:26 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-05-09 12:53:35 UTC
The Koha logo in the staff client header area is a transparent gif which doesn't look good if you style the background of that area with different colors. It should be replaced with a png image with alpha transparency.
Comment 1 Owen Leonard 2018-05-09 13:10:57 UTC Comment hidden (obsolete)
Comment 2 Claire Gravely 2018-05-11 06:48:00 UTC
Created attachment 75254 [details] [review]
Bug 20744: Replace staff client header Koha logo gif with transparent png

This patch replaces koha-logo-medium.gif with a fully-transparent png.
This patch also adds a white version in case someone finds it useful.

To test, apply the patch and clear your cache if necessary.

- View any page in the staff client and confirm that the Koha logo in
  the header area looks correct.
- Add the following to  IntranetUserCSS:

  .gradient {
     background: #46B9EA none;
  }

  - Reload the page and confirm that the Koha logo doesn't have a white
    fringe around the edges.
- Append this to the CSS you added to IntranetUserCSS above:

  h1#logo {
      background-image: url("/intranet-tmpl/prog/img/koha-logo-medium-white.png");
  }
  - Reload the page and confirm that the new white logo appears

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Jonathan Druart 2018-05-28 20:26:58 UTC
Created attachment 75611 [details] [review]
Bug 20744: Replace staff client header Koha logo gif with transparent png

This patch replaces koha-logo-medium.gif with a fully-transparent png.
This patch also adds a white version in case someone finds it useful.

To test, apply the patch and clear your cache if necessary.

- View any page in the staff client and confirm that the Koha logo in
  the header area looks correct.
- Add the following to  IntranetUserCSS:

  .gradient {
     background: #46B9EA none;
  }

  - Reload the page and confirm that the Koha logo doesn't have a white
    fringe around the edges.
- Append this to the CSS you added to IntranetUserCSS above:

  h1#logo {
      background-image: url("/intranet-tmpl/prog/img/koha-logo-medium-white.png");
  }
  - Reload the page and confirm that the new white logo appears

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens 2018-06-22 22:03:31 UTC
Awesome work all!

Pushed to master for 18.11.x
Comment 5 Martin Renvoize 2018-06-27 10:54:34 UTC
Enhancement, won't be backported.