Bug 20772 - Make request metadata editable and add price_paid field
Summary: Make request metadata editable and add price_paid field
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Andrew Isherwood
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 7317
Blocks: 20797
  Show dependency treegraph
 
Reported: 2018-05-16 11:15 UTC by Andrew Isherwood
Modified: 2019-10-14 19:56 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Added the new price_paid field to ILL requests
Version(s) released in:


Attachments
Bug 20772: Add 'illrequestattributes.readonly' (2.33 KB, patch)
2018-05-23 14:07 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequest.price_paid' (2.28 KB, patch)
2018-05-23 14:07 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: DO NOT PUSH - Schema update (2.74 KB, patch)
2018-05-23 14:07 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Borrowernumber should be read only (2.00 KB, patch)
2018-05-23 14:07 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Fix malformed class name (1.38 KB, patch)
2018-05-23 14:08 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Return cost & price_paid in API (1.21 KB, patch)
2018-05-23 14:08 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Display and edit of price_paid (2.63 KB, patch)
2018-05-23 14:08 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Bug preventing backend JS execution (993 bytes, patch)
2018-05-25 13:04 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequestattributes.readonly' (2.37 KB, patch)
2018-07-24 15:18 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Add 'illrequest.price_paid' (2.32 KB, patch)
2018-07-24 15:19 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: DO NOT PUSH - Schema update (2.78 KB, patch)
2018-07-24 15:21 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Borrowernumber should be read only (2.05 KB, patch)
2018-07-24 15:22 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Fix malformed class name (1.43 KB, patch)
2018-07-24 15:22 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Return cost & price_paid in API (1.25 KB, patch)
2018-07-24 15:23 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Display and edit of price_paid (2.67 KB, patch)
2018-07-24 15:23 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Bug preventing backend JS execution (1018 bytes, patch)
2018-07-24 15:24 UTC, Barry Cannon
Details | Diff | Splinter Review
Bug 20772: Add 'illrequestattributes.readonly' (2.38 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequest.price_paid' (2.33 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: DO NOT PUSH - Schema update (2.79 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Borrowernumber should be read only (2.10 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Fix malformed class name (1.46 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Return cost & price_paid in API (1.25 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Display and edit of price_paid (2.71 KB, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Bug preventing backend JS execution (1019 bytes, patch)
2018-10-05 10:01 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequestattributes.readonly' (2.38 KB, patch)
2018-10-05 10:59 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequest.price_paid' (2.33 KB, patch)
2018-10-05 10:59 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: DO NOT PUSH - Schema update (2.79 KB, patch)
2018-10-05 10:59 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Borrowernumber should be read only (2.10 KB, patch)
2018-10-05 10:59 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Fix malformed class name (1.46 KB, patch)
2018-10-05 11:00 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Return cost & price_paid in API (1.25 KB, patch)
2018-10-05 11:00 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Display and edit of price_paid (2.71 KB, patch)
2018-10-05 11:00 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Bug preventing backend JS execution (1019 bytes, patch)
2018-10-05 11:00 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: (follow-up) Fix DB updates and templates (7.13 KB, patch)
2018-10-05 11:00 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequestattributes.readonly' (2.42 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: Add 'illrequest.price_paid' (2.37 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: DO NOT PUSH - Schema update (2.83 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: Borrowernumber should be read only (2.15 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: Fix malformed class name (1.51 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: Return cost & price_paid in API (1.30 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: Display and edit of price_paid (2.75 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: Bug preventing backend JS execution (1.04 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: (follow-up) Fix DB updates and templates (7.16 KB, patch)
2018-10-05 11:06 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: (QA follow-up) Add a missing html filter (1.25 KB, patch)
2018-10-05 11:39 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20772: (follow-up) Add unit test (1.08 KB, patch)
2018-10-08 16:49 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 20772: Add 'illrequestattributes.readonly' (2.47 KB, patch)
2018-10-13 11:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: Add 'illrequest.price_paid' (2.42 KB, patch)
2018-10-13 11:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: Borrowernumber should be read only (2.21 KB, patch)
2018-10-13 11:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: Fix malformed class name (1.57 KB, patch)
2018-10-13 11:26 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: Return cost & price_paid in API (1.36 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: Display and edit of price_paid (2.81 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: Bug preventing backend JS execution (1.11 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: (follow-up) Fix DB updates and templates (7.21 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: (QA follow-up) Add a missing html filter (1.31 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: (follow-up) Add unit test (1.13 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: DBRev 18.06.00.041 (6.44 KB, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20772: (QA follow-up) 'readonly' is a boolean (992 bytes, patch)
2018-10-13 11:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Isherwood 2018-05-16 11:15:24 UTC
Currently, when an ILL request is created a variety of metadata is gathered pertaining to that request.

1) Request specific metadata : This is metadata that relates directly to the request, such as requested date, request status etc.

2) Record specific metadata : This is metadata that relates to the record being requested, with some backends, such as BLDSS, this metadata is supplied by the backend. With other backends, such as FreeForm, this metadata is supplied by the requester.

3) Additional record specific metadata : When a request is placed for a partial work, such as a book chapter, additional metadata is supplied detailing the partial work. This metadata may be supplied by the backend (for example, article request from the BLDSS), or by the requester (for example, a request for a chapter from a book record from the BLDSS).

There is a requirement to be able to edit some of this metadata, according to these proposed rules:

1) This is already editable
2 & 3) *May* need to be editable, depending on it's origin. i.e. If the metadata has originated from a "canonical" source, such as BLDSS, it should not be editable. If, however, it has originated from the requester via, for example, the FreeForm backend, it *should* be editable.
Comment 1 Andrew Isherwood 2018-05-23 14:07:21 UTC
Created attachment 75491 [details] [review]
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'
Comment 2 Andrew Isherwood 2018-05-23 14:07:31 UTC
Created attachment 75492 [details] [review]
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'
Comment 3 Andrew Isherwood 2018-05-23 14:07:41 UTC
Created attachment 75493 [details] [review]
Bug 20772: DO NOT PUSH - Schema update

Schema update for illrequestattributes.readonly
Schema update for illrequests.price_paid
Comment 4 Andrew Isherwood 2018-05-23 14:07:50 UTC
Created attachment 75494 [details] [review]
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed
Comment 5 Andrew Isherwood 2018-05-23 14:08:01 UTC
Created attachment 75495 [details] [review]
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces
Comment 6 Andrew Isherwood 2018-05-23 14:08:10 UTC
Created attachment 75496 [details] [review]
Bug 20772: Return cost & price_paid in API
Comment 7 Andrew Isherwood 2018-05-23 14:08:20 UTC
Created attachment 75497 [details] [review]
Bug 20772: Display and edit of price_paid
Comment 8 Andrew Isherwood 2018-05-25 13:04:43 UTC
Created attachment 75563 [details] [review]
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it
Comment 9 Andrew Isherwood 2018-05-25 13:24:05 UTC
Test plan:

- Apply patches
- Enable ILL
- Ensure you have the FreeForm ILL backend available, a clone of the master branch here is required: https://github.com/PTFS-Europe/FreeForm
- Create an request ILL using the FreeForm backend, populate as much metadata as possible, ensuring to also supply some custom fields
- Save the request
- On the "Manage ILL request" page for the newly created request, select the "Edit request metadata"
- On the resulting edit page:
  => TEST: Ensure all entered metadata is displayed
  -  Add new values, remove values, change values, including custom fields
  -  Click "Update"
- On the resulting "Manage ILL request":
  => TEST: Ensure all metadata fields reflect their changed values
- Repeat the editing and updating process until you're happy it works
Comment 10 Barry Cannon 2018-07-24 15:18:46 UTC
Created attachment 77230 [details] [review]
Bug 20772: Add 'illrequestattributes.readonly'
Comment 11 Barry Cannon 2018-07-24 15:19:58 UTC
Created attachment 77231 [details] [review]
Bug 20772: Add 'illrequest.price_paid'
Comment 12 Barry Cannon 2018-07-24 15:21:28 UTC
Created attachment 77232 [details] [review]
Bug 20772: DO NOT PUSH - Schema update
Comment 13 Barry Cannon 2018-07-24 15:22:19 UTC
Created attachment 77233 [details] [review]
Bug 20772: Borrowernumber should be read only
Comment 14 Barry Cannon 2018-07-24 15:22:52 UTC
Created attachment 77234 [details] [review]
Bug 20772: Fix malformed class name
Comment 15 Barry Cannon 2018-07-24 15:23:29 UTC
Created attachment 77235 [details] [review]
Bug 20772: Return cost & price_paid in API
Comment 16 Barry Cannon 2018-07-24 15:23:53 UTC
Created attachment 77236 [details] [review]
Bug 20772: Display and edit of price_paid
Comment 17 Barry Cannon 2018-07-24 15:24:28 UTC
Created attachment 77237 [details] [review]
Bug 20772: Bug preventing backend JS execution
Comment 18 Barry Cannon 2018-07-24 15:25:44 UTC
Test plan:

- Apply patches
- Enable ILL
- Ensure you have the FreeForm ILL backend available, a clone of the master branch here is required: https://github.com/PTFS-Europe/FreeForm
- Create an request ILL using the FreeForm backend, populate as much metadata as possible, ensuring to also supply some custom fields
- Save the request
- On the "Manage ILL request" page for the newly created request, select the "Edit request metadata"
- On the resulting edit page:
  => TEST: Ensure all entered metadata is displayed
  -  Add new values, remove values, change values, including custom fields
  -  Click "Update"
- On the resulting "Manage ILL request":
  => TEST: Ensure all metadata fields reflect their changed values
- Repeat the editing and updating process until you're happy it works

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 19 Andrew Isherwood 2018-10-05 10:01:16 UTC
Created attachment 80010 [details] [review]
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 20 Andrew Isherwood 2018-10-05 10:01:19 UTC
Created attachment 80011 [details] [review]
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 21 Andrew Isherwood 2018-10-05 10:01:23 UTC
Created attachment 80012 [details] [review]
Bug 20772: DO NOT PUSH - Schema update

Schema update for illrequestattributes.readonly
Schema update for illrequests.price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 22 Andrew Isherwood 2018-10-05 10:01:27 UTC
Created attachment 80013 [details] [review]
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 23 Andrew Isherwood 2018-10-05 10:01:31 UTC
Created attachment 80014 [details] [review]
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 24 Andrew Isherwood 2018-10-05 10:01:34 UTC
Created attachment 80015 [details] [review]
Bug 20772: Return cost & price_paid in API

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 25 Andrew Isherwood 2018-10-05 10:01:38 UTC
Created attachment 80016 [details] [review]
Bug 20772: Display and edit of price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 26 Andrew Isherwood 2018-10-05 10:01:42 UTC
Created attachment 80017 [details] [review]
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 27 Katrin Fischer 2018-10-05 10:28:41 UTC
Some first QA notes:

- There are 2 database updates that add new columns. Can you please use AFTER/BEFORE column to make sure the sequence matches what we have in kohastructure.sql?

- This here should be simplified to be picked up by translations:
[% request.price_paid || "N/A" %]
Comment 28 Andrew Isherwood 2018-10-05 10:59:46 UTC
Created attachment 80027 [details] [review]
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 29 Andrew Isherwood 2018-10-05 10:59:50 UTC
Created attachment 80028 [details] [review]
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 30 Andrew Isherwood 2018-10-05 10:59:54 UTC
Created attachment 80029 [details] [review]
Bug 20772: DO NOT PUSH - Schema update

Schema update for illrequestattributes.readonly
Schema update for illrequests.price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 31 Andrew Isherwood 2018-10-05 10:59:57 UTC
Created attachment 80030 [details] [review]
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 32 Andrew Isherwood 2018-10-05 11:00:02 UTC
Created attachment 80031 [details] [review]
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 33 Andrew Isherwood 2018-10-05 11:00:07 UTC
Created attachment 80032 [details] [review]
Bug 20772: Return cost & price_paid in API

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 34 Andrew Isherwood 2018-10-05 11:00:12 UTC
Created attachment 80033 [details] [review]
Bug 20772: Display and edit of price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 35 Andrew Isherwood 2018-10-05 11:00:17 UTC
Created attachment 80034 [details] [review]
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

Signed-off-by: Barry Cannon <bc@interleaf.ie>
Comment 36 Andrew Isherwood 2018-10-05 11:00:21 UTC
Created attachment 80035 [details] [review]
Bug 20772: (follow-up) Fix DB updates and templates

Carry out changes requested in commenbt #27
Comment 37 Katrin Fischer 2018-10-05 11:06:08 UTC
Created attachment 80036 [details] [review]
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 38 Katrin Fischer 2018-10-05 11:06:13 UTC
Created attachment 80037 [details] [review]
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 39 Katrin Fischer 2018-10-05 11:06:18 UTC
Created attachment 80039 [details] [review]
Bug 20772: DO NOT PUSH - Schema update

Schema update for illrequestattributes.readonly
Schema update for illrequests.price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 40 Katrin Fischer 2018-10-05 11:06:23 UTC
Created attachment 80041 [details] [review]
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 41 Katrin Fischer 2018-10-05 11:06:27 UTC
Created attachment 80042 [details] [review]
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 42 Katrin Fischer 2018-10-05 11:06:31 UTC
Created attachment 80043 [details] [review]
Bug 20772: Return cost & price_paid in API

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 43 Katrin Fischer 2018-10-05 11:06:36 UTC
Created attachment 80044 [details] [review]
Bug 20772: Display and edit of price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 44 Katrin Fischer 2018-10-05 11:06:40 UTC
Created attachment 80045 [details] [review]
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 45 Katrin Fischer 2018-10-05 11:06:44 UTC
Created attachment 80046 [details] [review]
Bug 20772: (follow-up) Fix DB updates and templates

Carry out changes requested in commenbt #27

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 46 Katrin Fischer 2018-10-05 11:08:55 UTC
There is a known problem with the Type being empty when editing, this will be fixed in another bug report.

This is the starting patch for now. We will add dependencies for others as we go.

Note to Andrew: Please fix bug title and maybe text to go in the release notes to also mention the new price_paid field.
Comment 47 Katrin Fischer 2018-10-05 11:39:56 UTC
Created attachment 80051 [details] [review]
Bug 20772: (QA follow-up) Add a missing html filter
Comment 48 Andrew Isherwood 2018-10-08 16:49:19 UTC
Created attachment 80232 [details] [review]
Bug 20772: (follow-up) Add unit test

Add unit test for price_paid
Comment 49 Tomás Cohen Arazi 2018-10-13 10:59:52 UTC
I'm confused by the readonly attribute. How are we going to use it? (there's no reference on this patchset)
Comment 50 Tomás Cohen Arazi 2018-10-13 11:26:31 UTC
Created attachment 80566 [details] [review]
Bug 20772: Add 'illrequestattributes.readonly'

This patch adds a 'readonly' column to illrequestattributes. On a DB
upgrade it also populates all existing rows with 1, indicating 'read
only'

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 51 Tomás Cohen Arazi 2018-10-13 11:26:39 UTC
Created attachment 80567 [details] [review]
Bug 20772: Add 'illrequest.price_paid'

This patch adds a 'price_paid' column to 'illrequests'

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 52 Tomás Cohen Arazi 2018-10-13 11:26:47 UTC
Created attachment 80568 [details] [review]
Bug 20772: Borrowernumber should be read only

On the Manage Request page, borrowernumber should be read only, we do
not want users modifying the destination user once a request is placed

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 53 Tomás Cohen Arazi 2018-10-13 11:26:54 UTC
Created attachment 80569 [details] [review]
Bug 20772: Fix malformed class name

Supplier metadata elements have a dynamically formed class name, part of
the name is formed from the metadata key, this breaks if the key has a
space, so we replace spaces

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 54 Tomás Cohen Arazi 2018-10-13 11:27:00 UTC
Created attachment 80570 [details] [review]
Bug 20772: Return cost & price_paid in API

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 55 Tomás Cohen Arazi 2018-10-13 11:27:06 UTC
Created attachment 80571 [details] [review]
Bug 20772: Display and edit of price_paid

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 56 Tomás Cohen Arazi 2018-10-13 11:27:12 UTC
Created attachment 80572 [details] [review]
Bug 20772: Bug preventing backend JS execution

We should be 'PROCESS'ing any backend JS, not 'INCLUDE'ing it

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 57 Tomás Cohen Arazi 2018-10-13 11:27:20 UTC
Created attachment 80573 [details] [review]
Bug 20772: (follow-up) Fix DB updates and templates

Carry out changes requested in commenbt #27

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 58 Tomás Cohen Arazi 2018-10-13 11:27:29 UTC
Created attachment 80574 [details] [review]
Bug 20772: (QA follow-up) Add a missing html filter

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 59 Tomás Cohen Arazi 2018-10-13 11:27:38 UTC
Created attachment 80575 [details] [review]
Bug 20772: (follow-up) Add unit test

Add unit test for price_paid

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 60 Tomás Cohen Arazi 2018-10-13 11:27:44 UTC
Created attachment 80576 [details] [review]
Bug 20772: DBRev 18.06.00.041

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 61 Tomás Cohen Arazi 2018-10-13 11:27:50 UTC
Created attachment 80577 [details] [review]
Bug 20772: (QA follow-up) 'readonly' is a boolean

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 62 Tomás Cohen Arazi 2018-10-13 11:37:33 UTC
Pushed for 18.11. Thanks all!
Comment 63 Katrin Fischer 2018-10-13 12:06:01 UTC
(In reply to Tomás Cohen Arazi from comment #49)
> I'm confused by the readonly attribute. How are we going to use it? (there's
> no reference on this patchset)

The backends can use it to determine which fields can be edited and which cannot (is what I understood) :)
Comment 64 Martin Renvoize 2018-10-16 12:53:16 UTC
Enhancement, will not be backported to 18.05.x series.