Bug 20773 - bug 20724 follow-up - Database cleanup
Summary: bug 20724 follow-up - Database cleanup
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
Depends on: 20724
  Show dependency treegraph
Reported: 2018-05-16 14:20 UTC by Jonathan Druart
Modified: 2018-05-17 09:11 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:

Bug 20773: (bug 20724 follow-up) Add a simple db revision (1.47 KB, patch)
2018-05-16 14:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-05-16 14:20:21 UTC

Comment 1 Jonathan Druart 2018-05-16 14:20:52 UTC
Created attachment 75368 [details] [review]
Bug 20773: (bug 20724 follow-up) Add a simple db revision

We should correct bad data too.
This is a trivial, pragmatic approach. Instead of doing a complex
calculation with holidays etc. (as was done on 12063), we just add
MaxPickupDelay or 7 days to today probably resulting in a little bonus
time. Only for waiting holds. When the ReservesNeedReturns pref was not
Automatic, there should be no changes.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Jonathan Druart 2018-05-16 14:22:08 UTC
This change contains MySQLism (FQA)

And maybe it would be better to display a warning and provide a script to fix the data (In Discussion).