reports/itemslost.tt: <td><span title="[% item.itemlost_on %]"</span>[% item.itemlost_on | $KohaDates %]</span></td> The first "</span>" is wrong, it should be just ">"
Created attachment 75392 [details] [review] Bug 20774: Trivial HTML error in itemslost.tt This patch makes a minor correction to the markup of the lost items report template. To test, apply the patch and run the lost items report with parameters which will return results. The report results should look correct, and the page should validate with no relevant errors.
Comment on attachment 75392 [details] [review] Bug 20774: Trivial HTML error in itemslost.tt Review of attachment 75392 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt @@ -87,4 @@ > </td> > <td>[% item.biblio.author %]</td> > <td>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.itemlost', authorised_value => item.itemlost ) %] > - <td><span title="[% item.itemlost_on %]"</span>[% item.itemlost_on | $KohaDates %]</span></td> Oh my! Good catch.
<div class="lostitems-table_table_controls">↩ | <a href="#" class="SelectAll"><i class="fa fa-check"></i> Select all</a> |↩ <a href="#" class="ClearAll"><i class="fa fa-remove"></i> Clear all</a>↩ <span class="itemselection_actions">↩ | Actions:↩ ↩ <span class="itemselection_action_export" title="You should create a CSV profile for export_lost_items"><i class="fa fa-download"></i> Export selected items</a>↩ ↩ </span>↩ </div>↩ There's a stray /a in this section. Could you fix this too? I'll leave the text/javascripts for another bug. :)
(In reply to M. Tompsett from comment #3) > There's a stray /a in this section. Could you fix this too? I'll leave the > text/javascripts for another bug. :) This seems to be a symptom of a larger problem with the export feature which I'll try to address in a separate bug.
(In reply to Owen Leonard from comment #4) > (In reply to M. Tompsett from comment #3) > > There's a stray /a in this section. Could you fix this too? I'll leave the > > text/javascripts for another bug. :) > > This seems to be a symptom of a larger problem with the export feature which > I'll try to address in a separate bug. Having just retested with a CSV profile defined from Tools, and rechecking the page, I see what you are talking about. Another bug it is, no sense scope creeping.
Created attachment 75508 [details] [review] Bug 20774: Trivial HTML error in itemslost.tt This patch makes a minor correction to the markup of the lost items report template. To test, apply the patch and run the lost items report with parameters which will return results. The report results should look correct, and the page should validate with no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 75555 [details] [review] Bug 20774: Trivial HTML error in itemslost.tt This patch makes a minor correction to the markup of the lost items report template. To test, apply the patch and run the lost items report with parameters which will return results. The report results should look correct, and the page should validate with no relevant errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 18.11. Awesome work all, thank you.
This patch has been pushed to 18.05.x and will be in 18.05.01
Depends on Bug 9573 that is not in 17.11.x