Bug 20789 - Remove manual reference to OPACShowBarcode
Summary: Remove manual reference to OPACShowBarcode
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-19 19:57 UTC by Bernardo Gonzalez Kriegel
Modified: 2019-10-14 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket (2.48 KB, patch)
2018-05-28 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2018-05-19 19:57:04 UTC
There are some occurrences of OPACShowBarcode on manual, this syspref has been removed.

source/images.rst:84:.. |image84| image:: images/admin/globalprefs/OPACShowBarcode-noshow.png

source/images.rst:85:.. |image85| image:: images/admin/globalprefs/OPACShowBarcode-show.png

source/opac.rst:48:-  :ref:`OPACShowBarcode` = Don't show
Comment 1 Katrin Fischer 2018-05-19 21:31:12 UTC
Patch coming.
Comment 2 Katrin Fischer 2018-05-28 21:42:15 UTC
Created attachment 75614 [details] [review]
Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket

Bug 19453 "fixed" the fund validation that never actually worked. This validation should be removed altogether instead. It is overly simplistic and simply checks to see if each record in the batch has a fund selected regardless of whether that record will be imported or not.

In addition, the code completely ignores items generated by MarcItemFieldsToOrder such that even if items on that page have a fund selected, the javascript forces the librarian to make a selection from the left-hand fund pulldown even though it will not be used.

Considering this bad validation is basically 'new' as it never worked before, the most sensible course of action would be to 'undo' the change and remove the validation.

Test Plan:
1) Add records to a basket from an import batch
2) Select only some of those items in the batch
3) Note Koha will not let you import them unless you set funds for *all*
   records in the batch
4) Apply this patch
5) Note Koha no longer forces a budget to be selected in the pulldown

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2018-05-28 21:44:20 UTC
Comment on attachment 75614 [details] [review]
Bug 20798: Client side validation for for fund selection prevents adding only some records to a basket

Wrong bug...
Comment 4 Katrin Fischer 2018-05-28 21:44:59 UTC
Fixed in the manual.