1 - Add a enw system preference "Don'tForgiveLostAfter" which would allow specification of a range of time 2 - modify the check in routine to check the value of the itemlost_on field and only refund if before this time 3 - Add feedback for circulation staff to alert that item was lost but fee is not refunded
Hi Kyle, can you explain what FY18 means?
(In reply to Katrin Fischer from comment #1) > Hi Kyle, can you explain what FY18 means? I have no idea, maybe JesseM does ; ) I have updated the title to actually describe the requires.
Any updates on bug 20815? Carnegie team
FY18 means Fiscal year 2018 Hi this bug is attached to our development New System Pref, “Don’t forgive lost after(set date), modify checkin routine to check the value of the itemlost_on field. My superiors want this bug pushed, thank you
Hi Brian, We understand the urgency for your library. This bug is currently assigned and in development. When the feature is ready, tested and passed QA it will be pushed into a release of Koha. Thanks! joy (In reply to Brian from comment #4) > FY18 means Fiscal year 2018 > > Hi this bug is attached to our development New System Pref, “Don’t forgive > lost after(set date), modify checkin routine to check the value of the > itemlost_on field. > > My superiors want this bug pushed, thank you
Created attachment 98772 [details] [review] Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t
Created attachment 98929 [details] [review] Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t
Created attachment 99038 [details] [review] Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t Signed-off-by: Deb Stephenson <DStephen@dubuque.lib.ia.us>
CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Created attachment 105141 [details] [review] Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t Signed-off-by: Deb Stephenson <DStephen@dubuque.lib.ia.us>
Please fix! FAIL t/db_dependent/Circulation.t OK critic FAIL forbidden patterns forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 3998) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4001) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4073) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4076) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4148) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4151) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4223) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 4226)
Well, or check at least :)
Created attachment 106575 [details] [review] Bug 20815: Do not use compare float with precision
Created attachment 106606 [details] [review] Bug 20815: Add ability to choose if lost fee is refunded based on length of time item has been lost This adds the ability to not refund lost item fees on return if the item has been lost for more than a given number of days. Test Plan: 1) Set the new system preference NoRefundOnLostReturnedItemsAge to a number of days 2) Find a lost item that has been lost longer than that NoRefundOnLostReturnedItemsAge days which would have otherwise been refunded 3) Return the item 4) Note no refund on the lost item fee was processed, the fee remains unchanged 5) prove t/db_dependent/Circulation.t Signed-off-by: Deb Stephenson <DStephen@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 106607 [details] [review] Bug 20815: Do not use compare float with precision Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 106608 [details] [review] Bug 20815: (QA follow-up) Add message to database update / rephrase pref - Make pref use "checked in" instead of "returned". - Add message to database update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 107165 [details] [review] Bug 20815: Tests refactoring Some code were duplicated.
Hi Kyle, In my understanding the tests don't cover the changes in AddIssue, can you provide some please?
Created attachment 107177 [details] [review] Bug 20815: Add unit tests for changes to AddIssue
Pushed to master for 20.11, thanks to everybody involved!
enhancement will not be backported to 20.05.x series
I changed the component from "Architecture, internals and plumbing" to "System administration" so that it appears under Administration in the release notes. I hope this is ok. If not, feel free to change it back :)