Bug 20876 - The form_serialized_itype cookie is not used and should be removed
Summary: The form_serialized_itype cookie is not used and should be removed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 18081
  Show dependency treegraph
 
Reported: 2018-06-04 14:27 UTC by Katrin Fischer
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20876: The form_serialized_itype cookie is not used and should be removed (2.39 KB, patch)
2018-06-04 14:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20876: The form_serialized_itype cookie is not used and should be removed (2.45 KB, patch)
2018-06-04 19:25 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20876: The form_serialized_itype cookie is not used and should be removed (2.54 KB, patch)
2018-06-05 11:53 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-06-04 14:27:49 UTC
The form_serialized_itype cookie is not used and should be removed. Item type limits for advanced searches are stored in the  form_serialized_lmits cookie instead.
Comment 1 Owen Leonard 2018-06-04 14:46:25 UTC
Created attachment 75776 [details] [review]
Bug 20876: The form_serialized_itype cookie is not used and should be removed

This patch removes references to a form_serialized_itype cookie which
appears in the code as part of the process of storing information used
in the generation of the "Return to the last advanced search" link.

To test, apply the patch and perform an advanced search in the OPAC
using several search options including a limit by item type. From the
search results page, follow the "Return to the last advanced search"
link. The advanced search form should appear with all the search options
you submitted before.
Comment 2 Katrin Fischer 2018-06-04 19:25:28 UTC
Created attachment 75789 [details] [review]
Bug 20876: The form_serialized_itype cookie is not used and should be removed

This patch removes references to a form_serialized_itype cookie which
appears in the code as part of the process of storing information used
in the generation of the "Return to the last advanced search" link.

To test, apply the patch and perform an advanced search in the OPAC
using several search options including a limit by item type. From the
search results page, follow the "Return to the last advanced search"
link. The advanced search form should appear with all the search options
you submitted before.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Marcel de Rooy 2018-06-05 11:53:10 UTC
Created attachment 75815 [details] [review]
Bug 20876: The form_serialized_itype cookie is not used and should be removed

This patch removes references to a form_serialized_itype cookie which
appears in the code as part of the process of storing information used
in the generation of the "Return to the last advanced search" link.

To test, apply the patch and perform an advanced search in the OPAC
using several search options including a limit by item type. From the
search results page, follow the "Return to the last advanced search"
link. The advanced search form should appear with all the search options
you submitted before.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Nick Clemens 2018-06-22 18:12:51 UTC
Awesome work all!

Pushed to master for 18.11.x
Comment 5 Martin Renvoize 2018-06-27 10:26:28 UTC
Pushed to 18.05.x for 18.05.02

With GDPR wipping everyone up into a frenzy at the moment, this one seemed pertinent to backport.
Comment 6 Fridolin Somers 2018-06-28 08:40:37 UTC
Pushed to 17.11.x for 17.11.08

Same has 18.05.x