Bug 20964 - search_patrons_to_anonymise selects different user than GetBorrowersWithIssuesHistoryOlderThan did.
Summary: search_patrons_to_anonymise selects different user than GetBorrowersWithIssue...
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-19 12:13 UTC by Martin Renvoize
Modified: 2019-10-14 19:58 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20964: Restore original filtering behaviour after bug 16966 (1.47 KB, patch)
2018-06-19 12:22 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2018-06-19 12:13:03 UTC
Bug 16966 sought to move the patron selection routines from GetBorrowersWithIssuesHistoryOlderThan in C4 to a dbic centric query in Koha::Patrons.

However, in do so, the resultant query was changed in such a way that rather than filtering patrons to anonymise by their home branch you are actually filtering by patrons who have ever had an biblio issued to them from a particular branch.

This is a surprising and unexpected change in functionality for users upgrading to 17.05.
Comment 1 Martin Renvoize 2018-06-19 12:22:07 UTC
Created attachment 76169 [details] [review]
Bug 20964: Restore original filtering behaviour after bug 16966

Bug 16966 altered the filter criteria of the anonymise selection, this
patch restores the original behaviour.
Comment 2 Martin Renvoize 2018-06-19 12:27:34 UTC
I take that back.. it's not a change of behaviour... but a counter-intuitive behaviour to start with :(