Created attachment 76211 [details] Screenshot showing note edit form in modal When looking at orders in a basket, each order has links to add or edit vendor and internal notes. I propose that we move a copy of the notes edit form to the basket template so that a modal can be used to edit notes.
Created attachment 76212 [details] [review] Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket.
1) Would it be possible to put the focus in the new input field after clicking on the link? I think it would improve usability to immediately allow typing the note instead of having to click again. But I notice it's the same for the message modal on the patron record. 2) Do you plan on changing the links on the parcel.pl page too? (new bug?)
Created attachment 76422 [details] [review] Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 76438 [details] [review] Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown.
Created attachment 76474 [details] [review] Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx, Owen!
Created attachment 76595 [details] [review] Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 76596 [details] [review] Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 76597 [details] [review] Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Reganing my QA token with Charles' additional sign-off - switching this to PQA.off I
Awesome work all! Pushed to master for 18.11
Enhancement, not backporting to the 18.05.x series.