Koha currently only displays the 866 Textual Holdings tag. It does not display the 867 Supplements or 868 Indexes Textual Holdings data.
Created attachment 76316 [details] [review] Bug 20986 Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display.
Test plan * Create a big with multiple 866, 867 and 868 tags * Note that the display in OPAC and Staff Details pages does not contain 867, 868 textual holdings and the 866 tags are run together on one line * Apply the patch * Now the 867 and 868 tags display * Additionally the 866,867 and 868 are displayed one per line
Created attachment 78861 [details] [review] Bug 20986 Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662
This works as expected.
Created attachment 79550 [details] [review] Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 79551 [details] [review] Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; }
Hi Joy and Ed, I feel the line breaks would break the layout for some people - I know it would not work well with our data. I am proposing a slight change that is more in line with the current layout but will still allow you to have what you wanted with one line of CSS. Could you take a look?
Created attachment 88095 [details] [review] Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 88096 [details] [review] Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 89605 [details] [review] Bug 20986: Add 867 and 868 holdings display Add line breaks in the 866 Holdings display in the OPAC details and Staff details page. Add 867 and 868 textual holdings with line breaks in the OPAC and Staff details display. Signed-off-by: Ed Veal <eveal@mckinneytexas.org> https://bugs.koha-community.org/show_bug.cgi?id=10662 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 89606 [details] [review] Bug 20986: (follow-up) Avoid br tags, but allow for line breaks to be added easily with CSS This patch removes the br tags from the XSLT in favor of some more spans and classes. This will allow to add the line breaks with one line of CSS: span.holdings_note_data { display:block; } Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07
I don't feel like maybe this was a thing that should have been in stable releases - it changes the front end OPAC and that's shocking for users. I don't think we need to take it out, but do be careful of these ones in the future please? Liz