Something is wrong with the JavaScript on the label item search. The visible problem is the missing datepickers on the date fields in the search form. To test: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window.
Seems ok here - https://screenshots.firefox.com/3CmAOf29z2fHLjzR/pro.kohadev.org
Strange, still broken for me. This is the URL: http://localhost:8081/cgi-bin/koha/labels/label-item-search.pl?batch_id=0&type=labels Looking at the source code the jquery libraries are at the bottom of the page, but there is a lot of JavaScript code above. Can you take another look and confirm you were looking on master?
Hum, it is failing now (?) ReferenceError: _ is not defined at line: var MSG_PLEASE_ENTER_A_VALID_DATE = (_("Please enter a valid date (should match %s)."));
Caused by commit 3c887b4e07acf9459767a7b934aa4f6c16cae534 Bug 19709: Move template JavaScript to the footer: Labels
Created attachment 76993 [details] [review] Bug 21050: Fix datepickers on LabelItemSearch calendar.inc must be in the jsinclude block when jsfooter is set Test plan: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Date picker should work now
Created attachment 77024 [details] [review] Bug 21050: Fix datepickers on LabelItemSearch calendar.inc must be in the jsinclude block when jsfooter is set Test plan: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Date picker should work now Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77553 [details] [review] Bug 21050: Fix datepickers on LabelItemSearch calendar.inc must be in the jsinclude block when jsfooter is set Test plan: - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Date picker should work now Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Awesome work all! Pushed to master for 18.11
Depends on (and is caused by) bug 19709 not in 18.05.x series.