Bug 21095 - Tests should expect ccodes facets now (since we have ccode facets)
Summary: Tests should expect ccodes facets now (since we have ccode facets)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 18322
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-20 02:05 UTC by Nick Clemens (kidclamp)
Modified: 2019-10-14 19:56 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21095: Add ccode facets info to tests (1.60 KB, patch)
2018-07-20 02:08 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 21095: Add ccode facets info to tests (1.67 KB, patch)
2018-07-20 07:19 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2018-07-20 02:05:54 UTC 
Since bug 18322 added ccode facets to zebra we should expect to get them in tests
Comment 1 Nick Clemens (kidclamp) 2018-07-20 02:08:35 UTC 
Created attachment 77146 [details] [review]
Bug 21095: Add ccode facets info to tests

To test:
1 - prove -v t/db_dependent/Search.t
2 - Koha asks "Why am I getting these crazy facets!?!"
3 - Apply patch
4 - prove -v t/db_dependent/Search.t
5 - Koha purrs (tests pass)
Comment 2 Martin Renvoize (ashimema) 2018-07-20 07:19:36 UTC 
Created attachment 77151 [details] [review]
Bug 21095: Add ccode facets info to tests

To test:
1 - prove -v t/db_dependent/Search.t
2 - Koha asks "Why am I getting these crazy facets!?!"
3 - Apply patch
4 - prove -v t/db_dependent/Search.t
5 - Koha purrs (tests pass)

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2018-07-20 07:20:32 UTC 
Going straight to Passed QA, works as described.. sorry Nick, muppet moment on my part there ;)
Comment 4 Nick Clemens (kidclamp) 2018-07-23 15:38:46 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-08-02 14:21:19 UTC 
Depends on bug 18322 which is not being backported to 18.05.x series.