t/00-testcritic.t is failing on master On line 318 we have: foreach $val (@values) { $val is a parameter passed in elsewhere, we should declare our own variable
Created attachment 77188 [details] [review] Bug 21103: Declare new parameter for loop iterator To test: prove -v t/00-testcritic.t it fails apply patch it passes
The third patch: "Bug 19604: Fix perlcritic "Loop iterator is not lexical" (1.20 KB, patch) 2018-07-31 11:22 UTC, Jonathan Druart" is a duplicate, except for variable names chosen. *** This bug has been marked as a duplicate of bug 19604 ***