Bug 21103 - Fix parameter reuse in Elasticsearch/QueryBuilder.pm
Summary: Fix parameter reuse in Elasticsearch/QueryBuilder.pm
Status: RESOLVED DUPLICATE of bug 19604
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 19604
Blocks:
  Show dependency treegraph
 
Reported: 2018-07-23 16:10 UTC by Nick Clemens
Modified: 2018-09-06 01:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21103: Declare new parameter for loop iterator (1.16 KB, patch)
2018-07-23 16:12 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-07-23 16:10:33 UTC
t/00-testcritic.t is failing on master

On line 318 we have:
foreach $val (@values) {

$val is a parameter passed in elsewhere, we should declare our own variable
Comment 1 Nick Clemens 2018-07-23 16:12:46 UTC
Created attachment 77188 [details] [review]
Bug 21103: Declare new parameter for loop iterator

To test:
prove -v t/00-testcritic.t
it fails
apply patch
it passes
Comment 2 Mark Tompsett 2018-09-06 01:22:29 UTC
The third patch: "Bug 19604: Fix perlcritic "Loop iterator is not lexical" (1.20 KB, patch) 2018-07-31 11:22 UTC, Jonathan Druart" is a duplicate, except for variable names chosen.

*** This bug has been marked as a duplicate of bug 19604 ***