Created attachment 77251 [details] The message is suitable to display upon "Remove Selected" or "Remove Selected Patrons" buttons clicked but the "Merge Selected Patrons" ones. In patron lists, There are two functions for us to handle patrons: "Removed Selected Patrons" and "Merge Selected Patrons". However, even for "Merge Selected Patrons" both , the messages showed either "Are you sure you want to remove the selected patrons?" or "You must select one patron or more patrons to remove." given that one had clicked selected patrons beforehand. It seemed the original files of translations or phases didn't have separate message contents for them individually. (Please check the link as well as the attached image: http://translate.koha-community.org/en_GB/18.05/translate/en-GB-staff-prog.po#unit=4679192 )
Also applies in master, setting version to master.
Created attachment 80210 [details] [review] Bug 21113: Corrections to patron merge confirmation prompt
Test Plan 1) Create a patron list (Home > Tools > Patron lists) with at least 2 users 2) View the list 3) Do NOT select any patrons before clicking 'Merge selected patrons' 4) Note the displayed message now says 'You must select two or more patrons to merge' 5) Select at least 2 patrons before clicking 'Marge selected patrons' 6) Note the displayed message now says 'Are you sure you want to merge the selected patrons?'
Created attachment 80287 [details] [review] Bug 21113: Corrections to patron merge confirmation prompt Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 80312 [details] [review] Bug 21113: Corrections to patron merge confirmation prompt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Depends on Bug 9302 not in 17.11.x