Bug 21124 - Non-Public note does not appear if added to item in MARC field
Summary: Non-Public note does not appear if added to item in MARC field
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 16.11
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-27 00:08 UTC by Daniel D'alessi
Modified: 2020-01-06 20:15 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Non-public note field when editing an item (28.21 KB, image/jpeg)
2018-07-27 00:08 UTC, Daniel D'alessi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel D'alessi 2018-07-27 00:08:41 UTC
Created attachment 77294 [details]
Non-public note field when editing an item

Adding a non-public note when in the item detail area (moredetail.pl) works as expected ie. it's visible in the normal title view, when returning/issuing, etc.

When adding a non-public note in the edit item screen (additem.pl?op=edititem), the note will save, but will not appear in the areas it is supposed to be visible.

Similarly this will occur if you try to batch modify a group of items adding a non-public note.
Comment 1 Lisette Scheer 2018-07-27 20:28:06 UTC
We had this problem, but were able to fix it via 'Koha to Marc Mapping' in the administrative section. 
We mapped Koha field itemnotes_nonpublic to marc tag 952 subfield x Non-public note. 

After this our support company was able to run a script to merge both the fields because over the years different people had used the different note fields and we didn't want to lose either of them. 

After the mapping, the notes works as expected when editing the item and in the moredetail.pl page. 

Lisette Scheer
Comment 2 Jonathan Druart 2018-07-30 19:15:07 UTC
That sounds like a configuration issue. As Lisette said make sure the field is correctly mapped.
Comment 3 Daniel D'alessi 2018-07-31 06:48:52 UTC
Thanks, I've checked our configuration as suggested and the field is mapped correctly: itemnotes_nonpublic 	952 	x 	Non-public note, but the problem still persists.

Additionally I checked the same issue on our test server which is on version 18.05, and I couldn't replicate the problem. Possibly something that was patched previously (although I couldn't find anything here)?
Comment 4 Katrin Fischer 2018-07-31 07:21:03 UTC
Hi Daniel,

have you checked it's the same mapping for all frameworks?

Before the column in items was introduced for the non-public note, we used to leave the mapping empty and the data was stored in items.more_subfields_xml. A mix of those old stored values with new ones would explain the behaviour you see. For example the display in the detail view only works with the new mapping.

Maybe you can run an SQL report to check if there is data in more_subfields_xml or if it's stored in itemnotes_nonpublic?

If the mapping is different, don't remap immediately, as you might want to think first about how to move your data.
Comment 5 Daniel D'alessi 2018-07-31 23:40:21 UTC
Hi Katrin,

Just looked in one of the MARC frameworks and noticed there was no Koha link in Advanced Constraints for Non-public note in the Live system. In our Test system, there is a link for the framework. I will check the other frameworks, but this looks like the problem.

So what you're saying is if I update the link it will wipe the current notes that are in there? I guess I better migrate the existing notes then :)

Thanks all for your help.
Comment 6 emjhet 2018-08-11 16:00:45 UTC
There are other problems with the non-public note field. Once the MARC field 952$x is mapped to items itemnotes_nonpublic (so that one can run reports that contain the 952$x), this note field begins to appear at check in and check out. If one has patron controlled circulation, then these fields are no longer "non-public." I would expect that a non-public note would be available only to those who can access/modify the item record. 

If you wish this to be a separate bug, please go ahead and do so.
Comment 7 Katrin Fischer 2018-08-11 17:50:42 UTC
What do you mean by patron-controlled circulation? Are you lettings users use the circulation module or are you saying that the notes are showing up in the web based self check? (different interface)
Comment 8 Hugo Agud 2019-01-11 07:51:58 UTC
Hi

I have seen this issue right now... as far I have been able to check

At MySQL we have two fields 

mysql itemnotes_nonpubl
mysql more_subfields_xml


when you add non public notes via 'edit items' the content is saved on more_subfields_xml
when you add non public notes via items tab at biblio record, the content is saved on itemnotes_nonpubl

the detail view of record shows the content of itemonotes_nonpubl and the table inside edit items show mysql_more_subfields_xml

then we have duplicate store fields for non_public_notes , and depending what you have filled you can see in one place or another
Comment 9 Katrin Fischer 2019-02-10 12:52:28 UTC
Hi Hugo, as explained in the other comments, this points to a configuration issue in your frameworks. Make sure your frameworks link the public note correctly to itemnotes_nonpublic in all cases.