Created attachment 77379 [details] [review] Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case)
Created attachment 77380 [details] [review] Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element.
Created attachment 77381 [details] [review] Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter
Created attachment 77382 [details] [review] Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized
Created attachment 77383 [details] [review] Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar
Created attachment 77391 [details] [review] Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 77392 [details] [review] Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 77393 [details] [review] Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 77394 [details] [review] Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 77395 [details] [review] Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 77408 [details] [review] Bug 21139: Floating toolbar - Remove dup id We should not have twice the same id, we always use fixFloat() on an element with an id and then duplicate this element. The id must be changed (just in case) Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77409 [details] [review] Bug 21139: Floating toolbars - Remove unecessary height This patch remove some pixels under the toolbar, they were used by the hidden element. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77410 [details] [review] Bug 21139: Floating toolbar - Remove horizontal scrollbar on resize To test: - add/edit a patron - resize the window => Without this patch a horizontal scrollbar appears when resized shorter Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77411 [details] [review] Bug 21139: Floating toolbar - Resize toolbar on window resize Prior to this patch the toolbar was not resized when the window was resized Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77412 [details] [review] Bug 21139: No table in toolbar We do not need this selector, we will not have a table in the toolbar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 18.11
Created attachment 77843 [details] [review] Bug 21139: (follow-up) Floating toolbars - Remove unecessary height Found where QAing bug 20935, we actually want the hidden toolbar to be the exact same height as the visible one. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to 18.05.x for 18.05.03.. awaiting followup to be pushed to master before grabbing it.
(In reply to Jonathan Druart from comment #17) > Created attachment 77843 [details] [review] [review] > Bug 21139: (follow-up) Floating toolbars - Remove unecessary height > > Found where QAing bug 20935, we actually want the hidden toolbar to be > the exact same height as the visible one. > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Follow-up pushed to master
Folllow-up pushed to 18.05.x for 18.05.04
Pushed to 17.11.x for 17.11.10