If you have a field marked as mandatory in your item framework and that field is styled by the Select2 plugin, it is not highlighted in the same way other fields are when you try to submit an empty mandatory value. Other fields get a yellow background. There is custom CSS for the Select2plugin which is supposed to do this job, but it doesn't appear to get getting applied.
Created attachment 77442 [details] [review] Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields This patch adds some CSS to target mandatory fields on the add item screen which are styled by the Select2 plugin. To test you must have at least one item field marked mandatory and linked to an authorized value. Open the add item form for an existing record. Try to submit the form without making a selection in the mandatory dropdown. You should get an alert warning you that you have empty mandatory fields, and the field should be highlighted in yellow.
Created attachment 77446 [details] [review] Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields This patch adds some CSS to target mandatory fields on the add item screen which are styled by the Select2 plugin. To test you must have at least one item field marked mandatory and linked to an authorized value. Open the add item form for an existing record. Try to submit the form without making a selection in the mandatory dropdown. You should get an alert warning you that you have empty mandatory fields, and the field should be highlighted in yellow. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77494 [details] [review] Bug 21148: Dropdowns styled by the Select2 plugin do not highlight missing required fields This patch adds some CSS to target mandatory fields on the add item screen which are styled by the Select2 plugin. To test you must have at least one item field marked mandatory and linked to an authorized value. Open the add item form for an existing record. Try to submit the form without making a selection in the mandatory dropdown. You should get an alert warning you that you have empty mandatory fields, and the field should be highlighted in yellow. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Pushed to 17.11.x for 17.11.10