Bug 21218 - Suppress Alert flag when checked_in_ok set
Summary: Suppress Alert flag when checked_in_ok set
Status: RESOLVED DUPLICATE of bug 22043
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-14 13:10 UTC by Colin Campbell
Modified: 2019-04-11 14:16 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch to clear alert flag on checkin of unissued item (1.15 KB, patch)
2018-08-14 14:05 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2018-08-14 13:10:27 UTC
This picks up on a comment on bug 13411 which introduced the checked_in_ok flag.

If we are saying the return is ok although the item was not on loan, logically we should not be setting the alert flag especially as 13411 suppresses the alert message so that there is no explanation of why the alert is triggered.

This is causing sites problems with some sites as items are apparently returned ok but routed to the exception bin without apparent reason.

The logic on some machines (92CQR an example) is to use the alert flag to indicate whether all is ok, irrespective of the other fields

Amend the logic so that the alert flag is not set if we are treating returns of unissued items as 'OK' returns.
Comment 1 Colin Campbell 2018-08-14 14:05:24 UTC
Created attachment 77788 [details] [review]
Patch to clear alert flag on checkin of unissued item

To Test using an emulator (see bug 13411) and a sip account with checked_in_ok="1" set. Return unissued items.

Without the patch applied you will see the response
101YNY20180814    145027AOCPL|AB502326000363|AQCPL|AJThe Hegel reader /|CK005|CRNFIC|CS193

With the patch applied it will be

101YNN20180814    145027AOCPL|AB502326000363|AQCPL|AJThe Hegel reader /|CK005|CRNFIC|CS193

The sixth character 'Y' is now appearing as 'N'
Comment 2 Colin Campbell 2019-04-11 14:16:32 UTC
Marked as duplicate of 22043 as the issue addressed is covered by that bug which will be in 19.05

*** This bug has been marked as a duplicate of bug 22043 ***