This picks up on a comment on bug 13411 which introduced the checked_in_ok flag. If we are saying the return is ok although the item was not on loan, logically we should not be setting the alert flag especially as 13411 suppresses the alert message so that there is no explanation of why the alert is triggered. This is causing sites problems with some sites as items are apparently returned ok but routed to the exception bin without apparent reason. The logic on some machines (92CQR an example) is to use the alert flag to indicate whether all is ok, irrespective of the other fields Amend the logic so that the alert flag is not set if we are treating returns of unissued items as 'OK' returns.
Created attachment 77788 [details] [review] Patch to clear alert flag on checkin of unissued item To Test using an emulator (see bug 13411) and a sip account with checked_in_ok="1" set. Return unissued items. Without the patch applied you will see the response 101YNY20180814 145027AOCPL|AB502326000363|AQCPL|AJThe Hegel reader /|CK005|CRNFIC|CS193 With the patch applied it will be 101YNN20180814 145027AOCPL|AB502326000363|AQCPL|AJThe Hegel reader /|CK005|CRNFIC|CS193 The sixth character 'Y' is now appearing as 'N'
Marked as duplicate of 22043 as the issue addressed is covered by that bug which will be in 19.05 *** This bug has been marked as a duplicate of bug 22043 ***