Bug 19799 highlighted a bad behaviour from our integration with apache on the packages.
Created attachment 78132 [details] [review] Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 78133 [details] [review] Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de>
QA: Looking here now
Created attachment 78321 [details] [review] Bug 21267: Set X-FORWARDED-PROTO https if required This patch makes the apache configuration for the reverse proxy (required for Plack) so it sets the X-FORWARDED-PROTO header correctly for Plack::Middleware::ReverseProxy to use it. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Ulrich Kleiber <ulrich.kleiber@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Since we actually resolve 19799 now (Changing language on OPAC redirects back to homepage), I will move that code to a new enh report.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.04
Pushed to 17.11.x for 17.11.10