If a patron account has been locked out, we cannot see it on the Patrons form in staff. Would be nice however.. We can reset the lockout by changing the password. (Unfortunately we cannot force a temporary password for one-time use. Not for this report now.) Before removing an account, it might be handy to have the feature of locking it from the Patrons form (or automatically by script?). (Might be a step e.g. in handling GDPR unsubscribe requests.)
Created attachment 80385 [details] [review] Bug 21312: Show lockout on Patrons form Just what the title says :) Specifically: moremember.pl Test plan: Check if you see the locked message on the patron form for an account that has been locked. (Either login_attempts<0 or >FailedLoginAttempts) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 84218 [details] [review] Bug 21312: Show lockout on Patrons form Just what the title says :) Specifically: moremember.pl Test plan: Check if you see the locked message on the patron form for an account that has been locked. (Either login_attempts<0 or >FailedLoginAttempts) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>
Created attachment 84246 [details] [review] Bug 21312: Show lockout on Patrons form Just what the title says :) Specifically: moremember.pl Test plan: Check if you see the locked message on the patron form for an account that has been locked. (Either login_attempts<0 or >FailedLoginAttempts) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 84247 [details] [review] Bug 21312: (QA follow-up) Ease translation I've changed the language a bit from "account locked out" to "account locked" and split it up to ease translation.
This is a bit problematic as it depends on bug 21336 which introduces the administrative lockout that is currently in Faild QA. The other is my follow-up suggesting some changes to the template and removing the "out". I am hesitating to move to BLOCKED because I think having the message on the patron account would be good to have now. Marcel or someone, would you mind taking a look at my follow-up?
Needs a rebase..
< 0 ? It's `login_attempts` int(4) DEFAULT '0',
(In reply to Jonathan Druart from comment #7) > < 0 ? > It's `login_attempts` int(4) DEFAULT '0', Ok, it comes from bug 21336, I did not see the deps. This sounds wrong to me.
Created attachment 88346 [details] [review] Bug 21312: Show lockout on Patrons form Just what the title says :) Specifically: moremember.pl Test plan: Check if you see the locked message on the patron form for an account that has been locked. (Either login_attempts<0 or >FailedLoginAttempts) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 88347 [details] [review] Bug 21312: (QA follow-up) Ease translation I've changed the language a bit from "account locked out" to "account locked" and split it up to ease translation.
(In reply to Katrin Fischer from comment #5) > The other is my follow-up suggesting some changes to the template and > removing the "out". I am hesitating to move to BLOCKED because I think > having the message on the patron account would be good to have now. > > Marcel or someone, would you mind taking a look at my follow-up? Fine with me. Thanks
(In reply to Jonathan Druart from comment #8) > Ok, it comes from bug 21336, I did not see the deps. > This sounds wrong to me. Wrong might not be the right word ;) We could move it to another field. Since locked and administratively locked are so close and exclusive, I just used one field as a status. Testing the field could be improved by centralizing in a method too, yes. But rather not here; this trivial report is just about showing the status.
Katrin: I got the impression that you were about to pass QA on it, or not ?
Created attachment 89312 [details] [review] Bug 21312: Show lockout on Patrons form Just what the title says :) Specifically: moremember.pl Test plan: Check if you see the locked message on the patron form for an account that has been locked. (Either login_attempts<0 or >FailedLoginAttempts) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 89313 [details] [review] Bug 21312: (QA follow-up) Ease translation I've changed the language a bit from "account locked out" to "account locked" and split it up to ease translation. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works well, no regressions.. Nicely translatable with the followup. Passing QA
(In reply to Martin Renvoize from comment #15) > Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.