Bug 21344 - C4::Biblio::MungeMarcPrice doesn't appear to be used anywhere
Summary: C4::Biblio::MungeMarcPrice doesn't appear to be used anywhere
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-14 11:14 UTC by Martin Renvoize (ashimema)
Modified: 2019-10-14 19:56 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2018-09-14 11:14:32 UTC
Whilst QAing bug 12310 I came accross the MungeMarcPrice routine inside C4::Biblio. This method does not appear to be called from anywhere in the current codebase and as such can likely be removed.
Comment 1 Katrin Fischer 2018-10-28 18:19:03 UTC
C4/Biblio.pm:        MungeMarcPrice
C4/Biblio.pm:            $subfield_value = MungeMarcPrice( $subfield_value );
C4/Biblio.pm:=head2 MungeMarcPrice
C4/Biblio.pm:sub MungeMarcPrice {
t/db_dependent/MungeMarcPrice.t:        MungeMarcPrice($price->{'string'}),
t/db_dependent/MungeMarcPrice.t:        MungeMarcPrice($price->{'string'}),

It's used in sub GetMarcPrice.

IIRC correctly, didn't follow the code trail, this is used trying to get a price from the MARC record when ordering from staged files.