Bug 21439 - Switch two-column templates to Bootstrap grid: Rotating collections
Summary: Switch two-column templates to Bootstrap grid: Rotating collections
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 20654
  Show dependency treegraph
 
Reported: 2018-09-27 15:18 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21439: Update two-column templates with Bootstrap grid: Rotating collections (7.22 KB, patch)
2018-09-27 15:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21439: Update two-column templates with Bootstrap grid: Rotating collections (7.27 KB, patch)
2018-09-28 12:45 UTC, Michal Denar
Details | Diff | Splinter Review
Bug 21439: Update two-column templates with Bootstrap grid: Rotating collections (7.32 KB, patch)
2018-10-08 12:39 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-09-27 15:18:17 UTC
These two-column rotating collections templates can be updated to use the Bootstrap grid.

 - rotating_collections/addItems.tt
 - rotating_collections/editCollections.tt
 - rotating_collections/rotatingCollections.tt
 - rotating_collections/transferCollection.tt
Comment 1 Owen Leonard 2018-09-27 15:22:26 UTC
Created attachment 79531 [details] [review]
Bug 21439: Update two-column templates with Bootstrap grid: Rotating collections

This patch modifies rotating collections templates to use the
Bootstrap grid instead of YUI.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Rotating collections
   - View rotating collection
   - Transfer rotating collection
   - Edit rotating collection
Comment 2 Michal Denar 2018-09-28 12:45:03 UTC
Created attachment 79575 [details] [review]
Bug 21439: Update two-column templates with Bootstrap grid: Rotating collections

This patch modifies rotating collections templates to use the
Bootstrap grid instead of YUI.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Rotating collections
   - View rotating collection
   - Transfer rotating collection
   - Edit rotating collection

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 3 Martin Renvoize 2018-10-08 12:39:32 UTC
Created attachment 80211 [details] [review]
Bug 21439: Update two-column templates with Bootstrap grid: Rotating collections

This patch modifies rotating collections templates to use the
Bootstrap grid instead of YUI.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Rotating collections
   - View rotating collection
   - Transfer rotating collection
   - Edit rotating collection

Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2018-10-08 12:39:56 UTC
All looks good from here.. passing qa
Comment 5 Nick Clemens 2018-10-17 19:24:35 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-10-26 12:44:29 UTC
Enhancement, will not be backported to 18.05.x series.