Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process.
Same has Bug 10326 for bulkmarcimport.pl
Created attachment 79949 [details] [review] Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same
Created attachment 80156 [details] [review] Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same Signed-off-by: David Nind <david@davidnind.com>
Created attachment 80241 [details] [review] Bug 21487: Disable CataloguingLog syspref in UNIMARC_sync_date_created_with_marc_biblio.pl Script UNIMARC_sync_date_created_with_marc_biblio.pl edits MARC record to define 099 $c and $d. This should not be registered as a cataloguing change in action_logs table. So script must disable CataloguingLog syspref (if enabled) during its process. Test plan : 1) Don't apply the patch yet 2) Have the CataloguingLog system preference set to 'Log' 3) Create a new record 4) Count entries in action_logs table 5) Run : UNIMARC_sync_date_created_with_marc_biblio.pl --run -v 6) Check the CataloguingLog system preference is still 'Log' 7) Count entries in action_logs table => there are more 8) Apply the patch 9) Repeate from 3) to 6) 10) Count entries in action_logs table => there are the same Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This follows the same pattern as batchRebuildItemsTables, however, we have found this can cause problems if the script is disrupted or errors halfway through (DB and cache have differing values and they aren't fixed until a cache is restarted) I would prefer to see something like bug 18816 - add a parameter to the functions that are logged to allow preventing that, rather than altering sysprefs
(In reply to Nick Clemens from comment #5) > This follows the same pattern as batchRebuildItemsTables, however, we have > found this can cause problems if the script is disrupted or errors halfway > through (DB and cache have differing values and they aren't fixed until a > cache is restarted) > > I would prefer to see something like bug 18816 - add a parameter to the > functions that are logged to allow preventing that, rather than altering > sysprefs I agree, I'll try to find time for that. Any help is welcomed.
Changing out of discussion - I think agreement to add a parameter was reached.