Bug 21488 - Receiving transfered items should be done with a 'receive' button instead of 'cancel'
Summary: Receiving transfered items should be done with a 'receive' button instead of ...
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2018-10-04 13:33 UTC by Janet McGowan
Modified: 2020-01-06 20:14 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12488: Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE (1.88 KB, patch)
2019-02-11 10:39 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janet McGowan 2018-10-04 13:33:22 UTC
In Circulation, Transfers to Receive - the button for receiving an item that has been transferred to your library doesn't make sense - it's called "Cancel Transfer". Receive Transfer would be more apt!
Comment 1 Katrin Fischer 2018-10-28 18:03:07 UTC
Hi Janet, 

I just tested and I think the behaviour is correct:

1) Put an item in transfer from Fairview to Fairfield
Item reads: In transit from Fairview to Fairfield since 28.10.2018
2) Cancel transfer
Item reads: Current library: Fairview and no transit message.

I think Cancel really means cancelling here - receiving would be done by checking the item in.
Comment 2 Aleisha Amohia 2018-12-18 23:00:35 UTC
(In reply to Katrin Fischer from comment #1)
> Hi Janet, 
> 
> I just tested and I think the behaviour is correct:


Can we set this bug to Invalid if current behaviour is correct?
Comment 3 Katrin Fischer 2018-12-18 23:40:24 UTC
Janet, please reopen if I misunderstood!
Comment 4 Martin Renvoize 2019-02-11 10:39:29 UTC
Created attachment 84962 [details] [review]
Bug 12488: Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE

On MySQL >= 5.5 bulkmarcimport.pl with the -d (delete) switch gives
an error like "Cannot truncate a table referenced in a foreign
key constraint". This patch proposes to replace the offending
TRUNCATE with DELETE. Auto incerement counters are reset to 1 to
preserve the functionality from TRUNCATE.

To test:
- Make sure you havae a test database with some records and items
- Run bulkmarcimport.pl with the -d switch
- Observe the error described above
- Apply this patch
- Run bulkmarcimport.pl with the -d switch again
- Observe the lack of an error
- Verify that the newly imported records and items have biblionumber
  and itemnumbers starting with 1

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-02-11 10:44:28 UTC
oops, wrong bug.. ignore